Hide default bundle id error when xcresult detects an error#101993
Merged
fluttergithubbot merged 1 commit intoflutter:masterfrom Apr 15, 2022
Merged
Hide default bundle id error when xcresult detects an error#101993fluttergithubbot merged 1 commit intoflutter:masterfrom
fluttergithubbot merged 1 commit intoflutter:masterfrom
Conversation
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Apr 15, 2022
blasten
reviewed
Apr 15, 2022
| if (!issueDetected && _needUpdateSigningIdentifier(xcodeBuildExecution)) { | ||
| issueDetected = true; | ||
| logger.printError(''); | ||
| logger.printError('It appears that your application still contains the default signing identifier.'); |
There was a problem hiding this comment.
could use logger.printBox for consistency with Android
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR make sure the default bundle id error only shows when xcresult doesn't detect errors.
Fixes #100723
sample output:
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.