This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Use track-widget-creation transformer included in the sdk.#8994
Closed
jacob314 wants to merge 1 commit intoflutter:masterfrom
Closed
Use track-widget-creation transformer included in the sdk.#8994jacob314 wants to merge 1 commit intoflutter:masterfrom
jacob314 wants to merge 1 commit intoflutter:masterfrom
Conversation
Contributor
Author
|
This CL depends on https://dart-review.googlesource.com/c/sdk/+/102920 |
Contributor
Author
|
This CL won't pass until the matching dart-sdk change has landed first. |
askeksa-google
approved these changes
May 18, 2019
askeksa-google
left a comment
There was a problem hiding this comment.
LGTM. Seems even cleaner this way.
7ad3f3e to
98ef7d6
Compare
This improves performance as the version in the SDK is able to work more incrementally and avoids creating an expensive ClassHierarchy. There is now no measureable performance difference with the option so the kernel transformer can be enabled by default.
98ef7d6 to
12fba27
Compare
This was referenced May 22, 2019
Contributor
|
@terrylucas any updates here? |
Contributor
|
Finally, 1.6.3 of Flutter has the dart-sdk track-widget-creation checkin. Was able to apply this CL, successfully compile, Flutter run launches with --track-widget-creation (by default) and DevTools inspector works. Awaiting Travis test passes and will apply CL (minor change DEPS reverted, Dart-sdk SHA was updated). |
Contributor
|
I have committed this CL (see #9085) patched in Jacob's original with a few minor changes DEPS (used tip dart-sdk SHA) and a merge conflict in frontend_server/lib/server.dart |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves performance as the version in the SDK is able to work more
incrementally and avoids creating an expensive ClassHierarchy.
There is now no measureable performance difference with the option so the
kernel transformer can be enabled by default.
Test output results:
flutter test04:06 +4043 ~86:
flutter test --track-widget-creation04:06 +4051 ~78: