This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Support in/out of list announcements on Android#6917
Closed
Conversation
Contributor
Author
|
This should be on my fork, not the flutter one. Will reopen. |
Contributor
Author
|
Opened from correct fork on #6918 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#22876
This makes it so that TalkBack will announce in/out of list under the following conditions:
We really should expose semantics properties for row and column counts, to better support multi-dimensional list-like widgets (like GridView, or third party widgets that want to have better scrolling semantics).
I've added a Predicate utility class because even with Lambda support in Java 1.8, we won't be able to use
java.util.function.Predicate(only available in API 24+).