This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reverts "Hooks up framework wide gamut to engine wide gamut (#54567)"#54884
Merged
auto-submit[bot] merged 1 commit intomainfrom Aug 30, 2024
Merged
Conversation
This reverts commit e3a15e1.
fluttergithubbot
approved these changes
Aug 30, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 30, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 30, 2024
flutter/engine@da87db6...9c3f66d 2024-08-30 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland: Framework wide color (#54415) (#54737)" (flutter/engine#54885) 2024-08-30 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Hooks up framework wide gamut to engine wide gamut (#54567)" (flutter/engine#54884) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…4385) flutter/engine@da87db6...9c3f66d 2024-08-30 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland: Framework wide color (flutter#54415) (flutter#54737)" (flutter/engine#54885) 2024-08-30 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Hooks up framework wide gamut to engine wide gamut (flutter#54567)" (flutter/engine#54884) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts: #54567
Initiated by: chingjun
Reason for reverting: Breaking internal tests. See b/363125155
Original PR Author: gaaclarke
Reviewed By: {jonahwilliams, chinmaygarde}
This change reverts the following previous change:
issue: flutter/flutter#127855
integration test: #54415
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.