This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Set cores in 'dimensions' instead of 'properties'#54747
Merged
auto-submit[bot] merged 1 commit intoflutter-3.25-candidate.0from Aug 23, 2024
Merged
Set cores in 'dimensions' instead of 'properties'#54747auto-submit[bot] merged 1 commit intoflutter-3.25-candidate.0from
auto-submit[bot] merged 1 commit intoflutter-3.25-candidate.0from
Conversation
properties gets routed to the build properties json. dimensions gets routed to the common_pb2.RequestedDimension buildbucket protobuf field.
Member
Author
zanderso
added a commit
that referenced
this pull request
Aug 26, 2024
#54747 worked, so I'm going to apply that change to all builders on main, and then we can CP it into the release branches. For flutter/flutter#152186
zanderso
added a commit
to zanderso/engine
that referenced
this pull request
Aug 26, 2024
flutter#54747 worked, so I'm going to apply that change to all builders on main, and then we can CP it into the release branches. For flutter/flutter#152186
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
propertiesgets routed to the build properties json that gets handed to the recipe.dimensionsgets routed to the common_pb2.RequestedDimension buildbucket protobuf field. See:https://flutter.googlesource.com/recipes/+/refs/heads/main/recipe_modules/shard_util/api.py#368