[canvaskit] Add animation detection for GIFs by harryterkelsen · Pull Request #54483 · flutter/engine

harryterkelsen · 2024-08-09T22:02:49Z

Detect if a GIF is animated to determine if we need to use Skia to decode it or if we can use tag decoding.

Fixes flutter/flutter#151911

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
I listed at least one issue that this PR fixes in the description above.
I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
I updated/added relevant documentation (doc comments with ///).
I signed the CLA.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

kevmoo · 2024-08-09T23:55:21Z

Nit: I wish the source pointed to some docs about how this all was interpreted.

Would ease maintenance later.

harryterkelsen · 2024-08-10T00:10:55Z

I linked to the GIF 89a spec in the doc comment for the class. Unfortunately since it's a text file I can't link to specific sections corresponding to the methods, but I stick to the terminology in the spec so the sections should be easy to find if you have the spec open.

mdebbar

LGTM!

mdebbar · 2024-08-12T16:29:55Z

lib/web_ui/lib/src/engine/image_format_detector.dart


-    // Read file size byte.
-    _readUint32();
+    // Skip reading file size byte.


nit:

Suggested change

// Skip reading file size byte.

// Skip reading file size bytes.

…54483)

…53413) Manual roll requested by zra@google.com flutter/engine@019f9e3...5909666 2024-08-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from 44635f897535 to 733062367c2e (1 revision) (#54541)" (flutter/engine#54552) 2024-08-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "macOS: Clean up create_ios_framework.py (#54543)" (flutter/engine#54550) 2024-08-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "macOS: refactor create_macos_framework.py (#54546)" (flutter/engine#54549) 2024-08-14 chris@bracken.jp macOS: refactor create_macos_framework.py (flutter/engine#54546) 2024-08-13 flar@google.com [DisplayList] Allow random access to ops through indexing (flutter/engine#54484) 2024-08-13 mit@google.com Update dartdoc for gpu.dart (flutter/engine#54529) 2024-08-13 chris@bracken.jp macOS: Clean up create_ios_framework.py (flutter/engine#54543) 2024-08-13 skia-flutter-autoroll@skia.org Roll Dart SDK from 44635f897535 to 733062367c2e (1 revision) (flutter/engine#54541) 2024-08-13 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 2LTVy4Gv76DcMpz4V... to MeV5i7xXXFPHF5sBK... (flutter/engine#54542) 2024-08-13 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Add animation detection for GIFs (flutter/engine#54483) 2024-08-13 matej.knopp@gmail.com Preserve background frame damage (flutter/engine#54540) 2024-08-13 6844906+zijiehe-google-com@users.noreply.github.com [fuchsia] Use BundledTestRunner from test-scripts (flutter/engine#54404) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 2LTVy4Gv76Dc to MeV5i7xXXFPH If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…utter#153413) Manual roll requested by zra@google.com flutter/engine@019f9e3...5909666 2024-08-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from 44635f897535 to 733062367c2e (1 revision) (flutter#54541)" (flutter/engine#54552) 2024-08-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "macOS: Clean up create_ios_framework.py (flutter#54543)" (flutter/engine#54550) 2024-08-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "macOS: refactor create_macos_framework.py (flutter#54546)" (flutter/engine#54549) 2024-08-14 chris@bracken.jp macOS: refactor create_macos_framework.py (flutter/engine#54546) 2024-08-13 flar@google.com [DisplayList] Allow random access to ops through indexing (flutter/engine#54484) 2024-08-13 mit@google.com Update dartdoc for gpu.dart (flutter/engine#54529) 2024-08-13 chris@bracken.jp macOS: Clean up create_ios_framework.py (flutter/engine#54543) 2024-08-13 skia-flutter-autoroll@skia.org Roll Dart SDK from 44635f897535 to 733062367c2e (1 revision) (flutter/engine#54541) 2024-08-13 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 2LTVy4Gv76DcMpz4V... to MeV5i7xXXFPHF5sBK... (flutter/engine#54542) 2024-08-13 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Add animation detection for GIFs (flutter/engine#54483) 2024-08-13 matej.knopp@gmail.com Preserve background frame damage (flutter/engine#54540) 2024-08-13 6844906+zijiehe-google-com@users.noreply.github.com [fuchsia] Use BundledTestRunner from test-scripts (flutter/engine#54404) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 2LTVy4Gv76Dc to MeV5i7xXXFPH If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Add animation detection for GIFs

db116fc

github-actions bot added the platform-web Code specifically for the web engine label Aug 9, 2024

Merge branch 'main' into canvaskit-detect-animated-gif

98e2e6d

mdebbar approved these changes Aug 12, 2024

View reviewed changes

fix typo

c9debe8

harryterkelsen added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 13, 2024

harryterkelsen requested a review from mdebbar August 13, 2024 19:46

auto-submit bot merged commit 2fcb51a into flutter:main Aug 13, 2024

engine-flutter-autoroll mentioned this pull request Aug 14, 2024

Roll Flutter Engine from 019f9e3f0744 to db034a514caf (8 revisions) flutter/flutter#153405

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 14, 2024

2fcb51a [canvaskit] Add animation detection for GIFs (flutter/engine#…

d35aeb2

…54483)

engine-flutter-autoroll mentioned this pull request Aug 14, 2024

Roll Flutter Engine from 019f9e3f0744 to 69f61b02a376 (9 revisions) flutter/flutter#153406

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 14, 2024

2fcb51a [canvaskit] Add animation detection for GIFs (flutter/engine#…

481390d

…54483)

engine-flutter-autoroll mentioned this pull request Aug 14, 2024

Manual roll Flutter Engine from 019f9e3f0744 to 087e290349ca (11 revisions) flutter/flutter#153410

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 14, 2024

2fcb51a [canvaskit] Add animation detection for GIFs (flutter/engine#…

77858a7

…54483)

engine-flutter-autoroll mentioned this pull request Aug 14, 2024

Manual roll Flutter Engine from 019f9e3f0744 to 5909666fdedb (12 revisions) flutter/flutter#153413

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 14, 2024

2fcb51a [canvaskit] Add animation detection for GIFs (flutter/engine#…

edbdf22

…54483)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[canvaskit] Add animation detection for GIFs#54483

[canvaskit] Add animation detection for GIFs#54483
auto-submit[bot] merged 3 commits intoflutter:mainfrom
harryterkelsen:canvaskit-detect-animated-gif

harryterkelsen commented Aug 9, 2024

Uh oh!

kevmoo commented Aug 9, 2024

Uh oh!

harryterkelsen commented Aug 10, 2024

Uh oh!

mdebbar left a comment

Uh oh!

mdebbar Aug 12, 2024

Uh oh!

harryterkelsen Aug 13, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	// Skip reading file size byte.
	// Skip reading file size bytes.

Conversation

harryterkelsen commented Aug 9, 2024

Pre-launch Checklist

Uh oh!

kevmoo commented Aug 9, 2024

Uh oh!

harryterkelsen commented Aug 10, 2024

Uh oh!

mdebbar left a comment

Choose a reason for hiding this comment

Uh oh!

mdebbar Aug 12, 2024

Choose a reason for hiding this comment

Uh oh!

harryterkelsen Aug 13, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants