This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[android] enqueue platform views for deletion.#54296
Closed
jonahwilliams wants to merge 8 commits intoflutter:mainfrom
Closed
[android] enqueue platform views for deletion.#54296jonahwilliams wants to merge 8 commits intoflutter:mainfrom
jonahwilliams wants to merge 8 commits intoflutter:mainfrom
Conversation
reidbaker
approved these changes
Aug 2, 2024
added 2 commits
August 2, 2024 09:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempted fix for thread unsafety. Defer destruction of platform view until end of platform view frame, persist as long as platform view is present in composition order like iOS does:
https://github.com/flutter/engine/blob/main/shell/platform/darwin/ios/framework/Source/FlutterPlatformViews.mm#L941-L945