This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Followup feedback on "Baby's First Triangle".#52718
Merged
auto-submit[bot] merged 1 commit intoflutter:mainfrom May 11, 2024
Merged
[Impeller] Followup feedback on "Baby's First Triangle".#52718auto-submit[bot] merged 1 commit intoflutter:mainfrom
auto-submit[bot] merged 1 commit intoflutter:mainfrom
Conversation
Addresses comments made after flutter#52703 landed.
Hixie
reviewed
May 10, 2024
| ``` | ||
|
|
||
| Notice we didn't do anything to perform the color mixing. That's because the rasterizer interpolates the values between stages. Since the varies depending on the pixel, we call these "varyings" and use the `v_` prefix for such variables. | ||
| We didn't do anything to perform the color mixing. That's because the rasterizer interpolates the values between stages. Since the varies depending on the pixel, we call these "varyings" and use the `v_` prefix for such variables. |
Contributor
There was a problem hiding this comment.
trivial nit, feel free to ignore
Maybe "We didn't do anything to perform the color mixing because the rasterizer interpolates..."?
Whichever, either's fine.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 11, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 11, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 11, 2024
flutter/engine@fad88cb...558a81d 2024-05-11 skia-flutter-autoroll@skia.org Roll Dart SDK from de30a5dbf169 to cbfaae24852c (2 revisions) (flutter/engine#52730) 2024-05-11 chinmaygarde@google.com [Impeller] Followup feedback on "Baby's First Triangle". (flutter/engine#52718) 2024-05-11 skia-flutter-autoroll@skia.org Roll Dart SDK from 13fc7db956c7 to de30a5dbf169 (1 revision) (flutter/engine#52728) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses comments made after #52703 landed.