This repository was archived by the owner on Feb 25, 2025. It is now read-only.
macOS fluttertextinputplugin drops selector called if no client#52495
Merged
auto-submit[bot] merged 2 commits intoflutter:mainfrom May 1, 2024
Merged
macOS fluttertextinputplugin drops selector called if no client#52495auto-submit[bot] merged 2 commits intoflutter:mainfrom
auto-submit[bot] merged 2 commits intoflutter:mainfrom
Conversation
| } | ||
|
|
||
| TEST(FlutterTextInputPluginTest, testComposingWithDeltasWhenSelectionIsActive) { | ||
| TEST(FlutterTextInputPluginTest, TestComposingWithDeltasWhenSelectionIsActive) { |
Contributor
There was a problem hiding this comment.
Thanks for catching that!
Renzo-Olivares
approved these changes
May 1, 2024
Contributor
Renzo-Olivares
left a comment
There was a problem hiding this comment.
LGTM from reading the issue and follow up explanations
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 1, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 1, 2024
flutter/engine@c536a14...2d73fa2 2024-05-01 magder@google.com Migrate PlatformMessageHandlerIos to ARC (flutter/engine#52226) 2024-05-01 47866232+chunhtai@users.noreply.github.com macOS fluttertextinputplugin drops selector called if no client (flutter/engine#52495) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The observed behavior is that if a keypress both reach framework and flutter textinputplugin selector and the keypress handler in framework causes the the textinputplugin to resign first responder, the selector will still go through even if the textinputplugin has already resigned.
The pr makes it so textinputplugin will ignore these selector call
fixes flutter/flutter#143270
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.