This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web:tests] switch to new HTML DOM matcher#52354
Merged
auto-submit[bot] merged 2 commits intoflutter:mainfrom Apr 24, 2024
Merged
[web:tests] switch to new HTML DOM matcher#52354auto-submit[bot] merged 2 commits intoflutter:mainfrom
auto-submit[bot] merged 2 commits intoflutter:mainfrom
Conversation
mdebbar
approved these changes
Apr 24, 2024
| @JS('innerHtml') | ||
| external set _innerHtml(JSString? html); | ||
| set innerHtml(String? html) => _innerHtml = html?.toJS; | ||
| @JS('innerHTML') |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 24, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 24, 2024
flutter/engine@b5d5832...b30c0a7 2024-04-24 15619084+vashworth@users.noreply.github.com Remove UIAccessibilityTraitKeyboardKey to fix touch typing (flutter/engine#52333) 2024-04-24 bdero@google.com [Impeller] Remove libtess2 from libflutter. (flutter/engine#52357) 2024-04-24 skia-flutter-autoroll@skia.org Roll Skia from 510b6766d907 to afcc1db27593 (2 revisions) (flutter/engine#52367) 2024-04-24 yjbanov@google.com [web:tests] switch to new HTML DOM matcher (flutter/engine#52354) 2024-04-24 jonahwilliams@google.com [Impeller] use spec constant for gaussian shader, rename, and reuse vertex sources. (flutter/engine#52361) 2024-04-24 jonahwilliams@google.com [Impeller] delete points compute shader. (flutter/engine#52346) 2024-04-24 byoungchan.lee@gmx.com [darwin] Update pixel format handling in FlutterTexture (flutter/engine#52326) 2024-04-24 jonahwilliams@google.com [Impeller] make drawAtlas always use porterduff or vertices_uber shader (flutter/engine#52348) 2024-04-24 magder@google.com Migrate ios_surface files to ARC (flutter/engine#52139) 2024-04-24 skia-flutter-autoroll@skia.org Roll Dart SDK from f470eaaf6e6d to 38c43a01a51e (1 revision) (flutter/engine#52365) 2024-04-24 skia-flutter-autoroll@skia.org Roll Skia from b5dd23bd29df to 510b6766d907 (16 revisions) (flutter/engine#52364) 2024-04-24 jason-simmons@users.noreply.github.com Fix some warnings reported by recent versions of clang-tidy (flutter/engine#52349) 2024-04-24 skia-flutter-autoroll@skia.org Roll Skia from e15464e6e982 to b5dd23bd29df (1 revision) (flutter/engine#52353) 2024-04-24 skia-flutter-autoroll@skia.org Roll Dart SDK from 5227dc5103f6 to f470eaaf6e6d (1 revision) (flutter/engine#52359) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the over-architected and under-utilized
canonicalizeHtmlandHtmlComparisonMode. Replace with a newhasHtmlmatcher.The new matcher produces considerably better error messages when matching fails (see
matchers_test.dartfor multiple examples). It also allows focusing on particular parts of the DOM rather than looking for a full match. This way a test can test just the functionality it cares about, and it can skip specifying what unrelated parts should look like (i.e. it prevents over-testing). For example, let's say you want to test that an<flt-semantics>element has anaria-labelattribute. You can use a DOM pattern that specified just that:This will check for the existence of
<flt-semantics>andaria-label="hello". It will ignore everything else that's unrelated to ARIA labels. For example, the element may have its geometry specified in thestyleattribute, anidattribute, and many other things, but if the test doesn't care, it doesn't need to specify those things (it can, if needs to though). This also applies tostyleproperties. See more examples in thematchers_test.dartfile.