This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[et] Don't require the --verbose flag when requesting a ci/ build#52339
Merged
zanderso merged 1 commit intoflutter:mainfrom Apr 23, 2024
Merged
[et] Don't require the --verbose flag when requesting a ci/ build#52339zanderso merged 1 commit intoflutter:mainfrom
zanderso merged 1 commit intoflutter:mainfrom
Conversation
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 24, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 24, 2024
flutter/engine@7f89b43...fcb1060 2024-04-23 zanderso@users.noreply.github.com [et] Don't require the --verbose flag when requesting a ci/ build (flutter/engine#52339) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#52021 introduced a bug where
cibuild could only be specified when also passing the--verboseflag. This PR fixes the issue so that by default thehelpmessage will only showcibuilds when--verboseis passed tohelp, but thecibuilds can be specified even without the--verboseflag.