This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] organize shaders a bit, make filter shaders use same vertex source.#52113
Merged
auto-submit[bot] merged 2 commits intoflutter:mainfrom Apr 15, 2024
Merged
Conversation
chinmaygarde
approved these changes
Apr 14, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 15, 2024
…me vertex source. (flutter/engine#52113)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 16, 2024
flutter/engine@07ae93c...503e7e8 2024-04-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] moved to bgra10_xr (#52019)" (flutter/engine#52140) 2024-04-15 skia-flutter-autoroll@skia.org Roll Skia from d27e288efd54 to 0b5df0201734 (1 revision) (flutter/engine#52132) 2024-04-15 skia-flutter-autoroll@skia.org Roll Skia from 0fe107da5a4e to d27e288efd54 (6 revisions) (flutter/engine#52130) 2024-04-15 30870216+gaaclarke@users.noreply.github.com [Impeller] moved to bgra10_xr (flutter/engine#52019) 2024-04-15 skia-flutter-autoroll@skia.org Roll Skia from 9e20a146c024 to 0fe107da5a4e (33 revisions) (flutter/engine#52129) 2024-04-15 jonahwilliams@google.com [Impeller] Use Wang's formula for quad/cubic subdivision. (flutter/engine#52079) 2024-04-15 jonahwilliams@google.com [Impeller] organize shaders a bit, make filter shaders use same vertex source. (flutter/engine#52113) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega
pushed a commit
to gilnobrega/flutter
that referenced
this pull request
Apr 22, 2024
…6790) flutter/engine@07ae93c...503e7e8 2024-04-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] moved to bgra10_xr (flutter#52019)" (flutter/engine#52140) 2024-04-15 skia-flutter-autoroll@skia.org Roll Skia from d27e288efd54 to 0b5df0201734 (1 revision) (flutter/engine#52132) 2024-04-15 skia-flutter-autoroll@skia.org Roll Skia from 0fe107da5a4e to d27e288efd54 (6 revisions) (flutter/engine#52130) 2024-04-15 30870216+gaaclarke@users.noreply.github.com [Impeller] moved to bgra10_xr (flutter/engine#52019) 2024-04-15 skia-flutter-autoroll@skia.org Roll Skia from 9e20a146c024 to 0fe107da5a4e (33 revisions) (flutter/engine#52129) 2024-04-15 jonahwilliams@google.com [Impeller] Use Wang's formula for quad/cubic subdivision. (flutter/engine#52079) 2024-04-15 jonahwilliams@google.com [Impeller] organize shaders a bit, make filter shaders use same vertex source. (flutter/engine#52113) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
yuv_to_rgb_filter.vert, srgb_to_linear_filter.vert, linear_to_srgb_filter.vert, color_matrix_color_filter.vert were all indentical, so I replaced them with a single shader called ... filter.vert!