This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Make EmbedderExternalViewEmbedder present to the correct view#51719
Merged
auto-submit[bot] merged 4 commits intoflutter:mainfrom Mar 28, 2024
Merged
Make EmbedderExternalViewEmbedder present to the correct view#51719auto-submit[bot] merged 4 commits intoflutter:mainfrom
auto-submit[bot] merged 4 commits intoflutter:mainfrom
Conversation
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 28, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 28, 2024
flutter/engine@043af35...f71e5ad 2024-03-28 dkwingsmt@users.noreply.github.com Make EmbedderExternalViewEmbedder present to the correct view (flutter/engine#51719) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
philipfranchi
pushed a commit
to philipfranchi/flutter-relabel-widgets
that referenced
this pull request
Mar 28, 2024
) flutter/engine@043af35...f71e5ad 2024-03-28 dkwingsmt@users.noreply.github.com Make EmbedderExternalViewEmbedder present to the correct view (flutter/engine#51719) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR connects the view ID provided by the rasterizer to
EmbedderExternalViewEmbedder's presenting call (seeembedder_external_view_embedder.cc).This PR also contains a refactor (which actually takes the majority of LOC) that moves the specification of view ID from
PrepareFlutterViewtoSubmitFlutterView. Theflutter_view_idparameter inPrepareFlutterViewwas added in #46169. It turns out that we don't need the view ID throughout the preparation phase, so we can delay the specification to submission, which makes it feel cleaner.Tests
Existing tests are changed to verify that
SubmitFlutterViewreceive the correct view ID.The feature that
EmbedderExternalViewEmbeddersends the view ID to the presenting API is not tested for now, becauseEmbedderExternalViewEmbedderis typically tested inembedder_unittests, but it requires the embedder APIAddView. It will be tested in later changes toEmbedderExternalViewEmbedder.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.