Reverts the logic for calculating the TextField input text cursor position when inputting Korean characters (3.13.9)#51161
Conversation
…ition when inputting Korean characters (3.13.9) - Issue occurred since 3.16.x - flutter/flutter#140739
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
follow up on #51164 |
Reverts the logic for calculating the TextField input text cursor position when inputting Korean characters (3.13.9)
List which issues are fixed by this PR. You must list at least one issue.
However, when entering Korean text, the input cursor is located to the left of the entered character.
Recorded Video about the issue:
Before (origin/main branch)
https://github.com/flutter/engine/assets/121159478/116c849e-d149-46ce-b3e4-eadcf7239b76
Modified (origin/text_cursor_position_incorrect_windows)
https://github.com/flutter/engine/assets/121159478/61852bca-da6e-4864-89e1-7e787d67355b
Pre-launch Checklist
///).