This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Code consistency fixes in FlScrollingManager#50959
Merged
robert-ancell merged 7 commits intoflutter:mainfrom Feb 27, 2024
Merged
Code consistency fixes in FlScrollingManager#50959robert-ancell merged 7 commits intoflutter:mainfrom
robert-ancell merged 7 commits intoflutter:mainfrom
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
032ea12 to
5a56004
Compare
Contributor
|
test-exempt: code refactor with no semantic change |
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 28, 2024
2461280 Roll Fuchsia Linux SDK from JCdhkDSFXzHyPuP4I... to T1xAi_ww_mWEiDkVN... (flutter/engine#51011) 8940ea0 Code consistency fixes in FlScrollingManager (flutter/engine#50959) 21474ee [macOS] Use CVDisplayLink to drive repaint (flutter/engine#49159) 6f7b939 Fail lazily when 1+ Skia gold comparions fail. (flutter/engine#51010) 249daf5 Adjust Android emulator test timeouts (flutter/engine#51004)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.