This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] implement blur style solid#50892
Merged
gaaclarke merged 5 commits intoflutter:mainfrom Mar 5, 2024
Merged
Conversation
ba6d65f to
0a0989d
Compare
0a0989d to
4bdb5a1
Compare
Member
Author
|
@jonahwilliams @bdero friendly ping (i know you are both hitting stc hard, this is here if you need a break) |
jonahwilliams
approved these changes
Mar 5, 2024
Comment on lines
271
to
274
| bool did_render = true; | ||
| did_render = blurred.Render(renderer, pass) && did_render; | ||
| did_render = snapshot_entity.Render(renderer, pass) && did_render; | ||
| return did_render; |
Contributor
There was a problem hiding this comment.
Suggested change
| bool did_render = true; | |
| did_render = blurred.Render(renderer, pass) && did_render; | |
| did_render = snapshot_entity.Render(renderer, pass) && did_render; | |
| return did_render; | |
| return blurred.Render(renderer, pass) && snapshot_entity.Render(renderer, pass); |
Member
Author
There was a problem hiding this comment.
That's not functionally equivalent because of short-circuiting. I was thinking we still want to render the snapshot even if the blurred draw fails for some reason.
Contributor
There was a problem hiding this comment.
If part of rendering fails then we should almost always be bailing out to a toplevel VALIDATION_LOG handler or error. partially correct is still wrong, so I'd prefer the simpler approach.
Member
Author
There was a problem hiding this comment.
I think those validation errors are noops in release builds though, right? Not a huge deal, done.
| did_render = snapshot_entity.Render(renderer, pass) && did_render; | ||
| return did_render; | ||
| }), | ||
| fml::MakeCopyable([blurred = blurred.Clone()](const Entity& entity) { |
Contributor
There was a problem hiding this comment.
I think it would be simpler to grab the coverage here and pass it in?
5 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 6, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 6, 2024
flutter/engine@49bc157...effcf97 2024-03-05 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Enable depth buffer clipping & Stencil-then-Cover path rendering. (#51209)" (flutter/engine#51217) 2024-03-05 30870216+gaaclarke@users.noreply.github.com [Impeller] implement blur style solid (flutter/engine#50892) 2024-03-05 xilaizhang@google.com [g3 roll] Revert "Remove unused drone_dimension field" (flutter/engine#51214) 2024-03-05 skia-flutter-autoroll@skia.org Roll Skia from 17677914dabf to 37947aec8c5c (5 revisions) (flutter/engine#51211) 2024-03-05 737941+loic-sharma@users.noreply.github.com Fix git hooks on Windows (flutter/engine#51203) 2024-03-05 bdero@google.com [Impeller] Enable depth buffer clipping & Stencil-then-Cover path rendering. (flutter/engine#51209) 2024-03-05 bdero@google.com [Impeller] Fix convex triangulation winding bug for multi-contour paths. (flutter/engine#51198) 2024-03-05 skia-flutter-autoroll@skia.org Roll Skia from 875b356e4d96 to 17677914dabf (2 revisions) (flutter/engine#51207) 2024-03-05 gspencergoog@users.noreply.github.com Skip configuration dependency if unit tests are disabled (flutter/engine#51179) 2024-03-05 chinmaygarde@google.com [Impeller] Implement YUV texture import and sampling for video player frames. (flutter/engine#50730) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes flutter/flutter#134178
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.