This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] add benchmarks for the stroke geometry entity code#50616
Merged
auto-submit[bot] merged 1 commit intoflutter:mainfrom Feb 13, 2024
Merged
Conversation
Contributor
Author
|
Some notes:
|
Contributor
Author
|
Sample output showing all of the combinations that are now run: |
| MAKE_STROKE_BENCHMARK_CAPTURE##uv(path, Butt, Bevel); \ | ||
| MAKE_STROKE_BENCHMARK_CAPTURE##uv(path, Butt, Miter); \ | ||
| MAKE_STROKE_BENCHMARK_CAPTURE##uv(path, Butt, Round); \ | ||
| MAKE_STROKE_BENCHMARK_CAPTURE##uv(path, Square, Bevel); \ |
Contributor
There was a problem hiding this comment.
Why leave off combos like Square + Miter?
Contributor
Author
There was a problem hiding this comment.
I could add them. I just thought that we should test one attribute at a time, as I describe in the "notes" comment above.
Contributor
There was a problem hiding this comment.
Oh, yeah - makes sense. I don't think we need the full combinatorial set.
Contributor
Author
There was a problem hiding this comment.
Though all combinations are tested for both uv and non-uv. I could go either way on filling out the rest of the cap/join combinations. Note that it would take us from 5 to 9 variations * 2 path types * UV/nonUV
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 14, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 14, 2024
flutter/engine@abb51c4...c0607a0 2024-02-14 31859944+LongCatIsLooong@users.noreply.github.com Temporarily change canvaskit kitchensink test to unblock the skia roll (flutter/engine#50617) 2024-02-13 flar@google.com [Impeller] add benchmarks for the stroke geometry entity code (flutter/engine#50616) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds benchmarks (and backend support methods) for tracking the performance of the stroking code in the entity geometry package.