This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Merged
Conversation
matanlurey
approved these changes
Feb 2, 2024
Contributor
|
\cc @zijiehe-google-com FYI |
CaseyHillers
approved these changes
Feb 2, 2024
Contributor
CaseyHillers
left a comment
There was a problem hiding this comment.
This SGTM. This may cause an issue on the release branches or 1P CPs, but I can do local reverts there until this is fixed.
keyonghan
reviewed
Feb 2, 2024
| - os=Linux | ||
| dimensions: | ||
| kvm: "1" | ||
| bringup: true |
Contributor
There was a problem hiding this comment.
Instead, we need to increase the timeout if #50058 is intended. Otherwise this will just keep flaking in staging due to timeout.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 2, 2024
auto-submit bot
pushed a commit
that referenced
this pull request
Feb 2, 2024
This reverts commit acb6fbc.
auto-submit bot
added a commit
that referenced
this pull request
Feb 2, 2024
Reverts #50288 Initiated by: zanderso This change reverts the following previous change: Original Description: For flutter/flutter#142811
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 2, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 2, 2024
8 tasks
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 2, 2024
flutter/engine@e292632...266d5d0 2024-02-02 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Move linux_fuchsia to staging" (flutter/engine#50294) 2024-02-02 zanderso@users.noreply.github.com Revert "[Fuchsia] Execute most of the testing/fuchsia/test_suites.yaml on debug and release builds" (flutter/engine#50291) 2024-02-02 zanderso@users.noreply.github.com Move linux_fuchsia to staging (flutter/engine#50288) 2024-02-02 tugorez@users.noreply.github.com Add the focus state related methods to the platform dispatcher (flutter/engine#50273) 2024-02-02 32242716+ricardoamador@users.noreply.github.com Add a link the different possible Android virtual device configs (flutter/engine#50267) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For flutter/flutter#142811