This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "[Impeller] round up subpass coverage when it is close to (and smaller) than root pass size."#50041
Merged
auto-submit[bot] merged 2 commits intomainfrom Jan 25, 2024
Merged
Conversation
… smaller) than root pass size."
bdero
approved these changes
Jan 25, 2024
Contributor
|
auto label is removed for flutter/engine/50041, Failed to merge flutter/engine/50041 with Pull request flutter/engine/50041 could not be merged: Required status check "ci.yaml validation" is expected.. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 25, 2024
… to (and smaller) than root pass size." (flutter/engine#50041)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 25, 2024
flutter/engine@55eefd5...b2167a9 2024-01-25 jonahwilliams@google.com [Impeller] write vertices geometry data to host buffer. (flutter/engine#49741) 2024-01-25 jonahwilliams@google.com Revert "[Impeller] round up subpass coverage when it is close to (and smaller) than root pass size." (flutter/engine#50041) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #49925
This did not improve benchmarks: https://flutter-flutter-perf.skia.org/e/?queries=device_type%3DPixel_7_Pro%26sub_result%3D90th_percentile_frame_rasterizer_time_millis%26sub_result%3D99th_percentile_frame_rasterizer_time_millis%26sub_result%3Daverage_frame_rasterizer_time_millis%26sub_result%3Dworst_frame_rasterizer_time_millis%26test%3Dnew_gallery_impeller_old_zoom__transition_perf&selected=commit%3D38910%26name%3D%252Carch%253Dintel%252Cbranch%253Dmaster%252Cconfig%253Ddefault%252Cdevice_type%253DPixel_7_Pro%252Cdevice_version%253Dnone%252Chost_type%253Dlinux%252Csub_result%253D99th_percentile_frame_rasterizer_time_millis%252Ctest%253Dnew_gallery_impeller_old_zoom__transition_perf%252C
From follow up investigation: some of the routes hit this optimization, while some did not as the the bounds size seems to depend on the exact contents.