Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Add support for exposing accessibility identifier as accessibilityIdentifier on iOS#48858

Merged
auto-submit[bot] merged 3 commits intoflutter:mainfrom
bartekpacia:feature/ios_add_accessibility_identifier
Dec 11, 2023
Merged

Add support for exposing accessibility identifier as accessibilityIdentifier on iOS#48858
auto-submit[bot] merged 3 commits intoflutter:mainfrom
bartekpacia:feature/ios_add_accessibility_identifier

Conversation

@bartekpacia
Copy link
Member

@bartekpacia bartekpacia commented Dec 9, 2023

This PR is a sibling of #47961 but for iOS

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@bartekpacia bartekpacia mentioned this pull request Dec 9, 2023
Merged
8 tasks
@bartekpacia bartekpacia marked this pull request as ready for review December 11, 2023 11:53
@bartekpacia bartekpacia requested a review from chunhtai December 11, 2023 11:53
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Dec 11, 2023
@bartekpacia
Add accessibility identifier to SemanticsProperties (#138331)
948523b 
This PR adds `String? identifier` to `Semantics` and `SemanticsProperties`. The `identifier` will be exposed on Android as `resource-id` and on iOS as `accessibilityIdentifier`.

Mainly targeted at #17988

Initial Engine PR with Android support: flutter/engine#47961
iOS Engine PR: flutter/engine#48858

### Migration

This change breaks the SemanticsUpdateBuilder API which is on the Framework<-->Engine border. For more details see [engine PR](flutter/engine#47961).

Steps:
part 1: [engine] add `SemanticsUpdateBuilderNew` flutter/engine#47961
**part 2: [flutter] use `SemanticsUpdateBuilderNew`**  <-- we are here
part 3: [engine] update `SemanticsUpdateBuilder` to be the same as `SemanticsUpdateBuilderNew`*
part 4: [flutter] use (now updated) `SemanticsUpdateBuilder` again.
part 5: [engine] remove `SemanticsBuilderNew`
chunhtai
chunhtai approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartekpacia bartekpacia added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 11, 2023
@auto-submit auto-submit bot merged commit c660860 into flutter:main Dec 11, 2023
@bartekpacia bartekpacia deleted the feature/ios_add_accessibility_identifier branch December 11, 2023 22:50
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 11, 2023
@engine-flutter-autoroll
c660860 Add support for exposing accessibility identifier as accessib…
f03e18b 
…ilityIdentifier on iOS (flutter/engine#48858)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 12, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 12, 2023
@engine-flutter-autoroll
c660860 Add support for exposing accessibility identifier as accessib…
416d932 
…ilityIdentifier on iOS (flutter/engine#48858)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Dec 12, 2023
@engine-flutter-autoroll
Roll Flutter Engine from d001419 to ea1a306 (5 revisions) (#139948)
4444bdf 
flutter/engine@d001419...ea1a306

2023-12-11 skia-flutter-autoroll@skia.org Roll Skia from bd5941d727be to 461256aac224 (1 revision) (flutter/engine#48897)
2023-12-11 matanlurey@users.noreply.github.com Move `third_party/yapf` to `flutter/third_party/yapf`. (flutter/engine#48847)
2023-12-11 skia-flutter-autoroll@skia.org Roll Skia from 17bd70326a49 to bd5941d727be (1 revision) (flutter/engine#48896)
2023-12-11 barpac02@gmail.com SemanticsUpdateBuilder migration: introduce `identifier` (flutter/engine#48882)
2023-12-11 barpac02@gmail.com Add support for exposing accessibility identifier as accessibilityIdentifier on iOS (flutter/engine#48858)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@nicerloop nicerloop mentioned this pull request May 21, 2024
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@chunhtai chunhtai chunhtai approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App platform-ios

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bartekpacia @chunhtai