Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] Dont copy the paint until we're sure that the RRect blur optimization will apply. #48298

Merged
auto-submit merged 2 commits into from
Nov 22, 2023
Merged

[Impeller] Dont copy the paint until we're sure that the RRect blur optimization will apply. #48298

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f77906
++
Nov 21, 2023
7ead8df
++
Nov 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions impeller/aiks/canvas.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,18 +193,18 @@ void Canvas::DrawPaint(const Paint& paint) {
bool Canvas::AttemptDrawBlurredRRect(const Rect& rect,
Scalar corner_radius,
const Paint& paint) {
Paint new_paint = paint;
if (new_paint.color_source.GetType() != ColorSource::Type::kColor ||
new_paint.style != Paint::Style::kFill) {
if (paint.color_source.GetType() != ColorSource::Type::kColor ||
paint.style != Paint::Style::kFill) {
return false;
}

if (!new_paint.mask_blur_descriptor.has_value() ||
new_paint.mask_blur_descriptor->style !=
FilterContents::BlurStyle::kNormal) {
if (!paint.mask_blur_descriptor.has_value() ||
paint.mask_blur_descriptor->style != FilterContents::BlurStyle::kNormal) {
return false;
}

Paint new_paint = paint;

// For symmetrically mask blurred solid RRects, absorb the mask blur and use
// a faster SDF approximation.

Expand Down