This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Run tests on either macOS 12 or 13#47606
Merged
auto-submit[bot] merged 1 commit intoflutter:mainfrom Nov 2, 2023
Merged
Conversation
17 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 2, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 2, 2023
flutter/engine@b11e318...1e2eee0 2023-11-02 skia-flutter-autoroll@skia.org Roll Skia from 2b3472da9888 to 306543797674 (5 revisions) (flutter/engine#47610) 2023-11-02 15619084+vashworth@users.noreply.github.com Run tests on either macOS 12 or 13 (flutter/engine#47606) 2023-11-02 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 32ukjtetQl4pbXfTw... to bhSlAQy4VM3Plrlh4... (flutter/engine#47611) 2023-11-02 dnfield@google.com [Impeller] Skia gold for flutter_tester dart tests. (flutter/engine#47066) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from 32ukjtetQl4p to bhSlAQy4VM3P If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation for migrating our fleet to macOS 13, we're updating tests to run on either macOS 12 or macOS 13.
I have run all tests on macOS 13: https://docs.google.com/spreadsheets/d/1-KOSOSF7uVA4KuqSMn9xz3IIJW78u8SXLYK2OAfe_Qg/edit?usp=sharing&resourcekey=0-df8Bj5PRS1IPBccPDdvRCQ
Note: I'm leaving subtests of
Linux linux_web_engineon Mac-12 since they're currently incompatible with MacOS 13.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.