This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] opt all vertex shader position/uvs into highp#42746
Merged
auto-submit[bot] merged 2 commits intoflutter:mainfrom Jun 12, 2023
Merged
[Impeller] opt all vertex shader position/uvs into highp#42746auto-submit[bot] merged 2 commits intoflutter:mainfrom
auto-submit[bot] merged 2 commits intoflutter:mainfrom
Conversation
jason-simmons
approved these changes
Jun 12, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 12, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 12, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 12, 2023
flutter/engine@33e0693...de68fba 2023-06-12 smartercallum@gmail.com Fix crash with CJK keyboard with emoji at end of text field (flutter/engine#42540) 2023-06-12 skia-flutter-autoroll@skia.org Roll Skia from 658b1d366758 to 6bdb0ef30cb6 (2 revisions) (flutter/engine#42778) 2023-06-12 jonahwilliams@google.com [Impeller] Correct attachment description for offscreen MSAA resolve. (flutter/engine#42753) 2023-06-12 tamird@google.com Remove dependency on memfs (flutter/engine#42773) 2023-06-12 skia-flutter-autoroll@skia.org Roll Skia from 0f974a0f8c10 to 658b1d366758 (1 revision) (flutter/engine#42776) 2023-06-12 skia-flutter-autoroll@skia.org Roll ANGLE from 3abbc4f99970 to 43ef50f389e9 (1 revision) (flutter/engine#42775) 2023-06-12 kjlubick@users.noreply.github.com Remove unnecessary #include of SkPromiseImageTexture (flutter/engine#42770) 2023-06-12 skia-flutter-autoroll@skia.org Roll Skia from 951123096e55 to 0f974a0f8c10 (5 revisions) (flutter/engine#42771) 2023-06-12 jonahwilliams@google.com [Impeller] opt all vertex shader position/uvs into highp (flutter/engine#42746) 2023-06-12 30870216+gaaclarke@users.noreply.github.com [Impeller] added debug info to frame debuggers like AGI (flutter/engine#42717) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#128605
f16 doesn't have enough resolution at large pixel values to be safely used for positions. Opt all shaders into highp. I think we might be able to get away with mediump for uv since values from 0-1 should have plenty of precisision, but we can worry about that later.