This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Replace SkSurface::flush methods with GrDirectContext methods#42425
Merged
kjlubick merged 4 commits intoflutter:mainfrom May 31, 2023
Merged
Replace SkSurface::flush methods with GrDirectContext methods#42425kjlubick merged 4 commits intoflutter:mainfrom
kjlubick merged 4 commits intoflutter:mainfrom
Conversation
jason-simmons
approved these changes
May 30, 2023
jason-simmons
approved these changes
May 30, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 31, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 31, 2023
flutter/engine@682bd0f...ee53c04 2023-05-31 kjlubick@users.noreply.github.com Replace SkSurface::flush methods with GrDirectContext methods (flutter/engine#42425) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
HinTak
added a commit
to HinTak/skia-m1xx-python
that referenced
this pull request
Aug 10, 2023
commit e3ca856e7ed6c285734dacf87faccdbf9a321f05
Author: Kevin Lubick <kjlubick@google.com>
Date: Wed Jul 26 08:58:05 2023 -0400
Remove legacy SkImage and SkSurface methods
Client CLs:
- http://ag/23168890
- http://ag/23171851
- http://ag/23473641
- http://ag/23494824
- http://cl/551209733
- https://crrev.com/c/4566404
- https://crrev.com/c/4705004
- flutter/engine#42425
- flutter/engine#43786
- flutter/engine#43965
Change-Id: I06c71cf6dc77aeaa3f78dec61c7b7c6eca688884
Bug: b/40045064
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/729776
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In https://skia-review.googlesource.com/c/skia/+/698237, Skia moved the SkSurface::flush* methods to GrDirectContext (and skgpu::ganesh::Flush). This updates Flutter to use those versions, which are drop-in replacements for the previous functionality.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.