This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Limit subpass textures and backdrop blurs to the current clip#42039
Merged
bdero merged 2 commits intoflutter:mainfrom May 15, 2023
Merged
[Impeller] Limit subpass textures and backdrop blurs to the current clip#42039bdero merged 2 commits intoflutter:mainfrom
bdero merged 2 commits intoflutter:mainfrom
Conversation
e55e686 to
e0cc2c7
Compare
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
jonahwilliams
approved these changes
May 15, 2023
Contributor
jonahwilliams
left a comment
There was a problem hiding this comment.
LGTM
Do you have additionally follow up work for this already scoped out?
Contributor
Author
|
Yes, I'm planning the following assuming this one sticks without issues:
|
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 15, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 15, 2023
flutter/engine@00f20fb...027ca79 2023-05-15 godofredoc@google.com Use release_build and os dimension consistently. (flutter/engine#42012) 2023-05-15 bdero@google.com [Impeller] Add interactive DrawPaint blend test (flutter/engine#42031) 2023-05-15 bdero@google.com [Impeller] Limit subpass textures and backdrop blurs to the current clip (flutter/engine#42039) 2023-05-15 skia-flutter-autoroll@skia.org Roll Dart SDK from c302a0252785 to d2b2ac829842 (1 revision) (flutter/engine#42051) 2023-05-15 ychris@google.com Upload xcresults to LUCI cloud storage (flutter/engine#41647) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced May 17, 2023
Contributor
|
We aren't going to cherry pick this due to its size. cc @bdero @jonahwilliams |
CaseyHillers
pushed a commit
to CaseyHillers/flutter
that referenced
this pull request
May 24, 2023
…6876) flutter/engine@00f20fb...027ca79 2023-05-15 godofredoc@google.com Use release_build and os dimension consistently. (flutter/engine#42012) 2023-05-15 bdero@google.com [Impeller] Add interactive DrawPaint blend test (flutter/engine#42031) 2023-05-15 bdero@google.com [Impeller] Limit subpass textures and backdrop blurs to the current clip (flutter/engine#42039) 2023-05-15 skia-flutter-autoroll@skia.org Roll Dart SDK from c302a0252785 to d2b2ac829842 (1 revision) (flutter/engine#42051) 2023-05-15 ychris@google.com Upload xcresults to LUCI cloud storage (flutter/engine#41647) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of flutter/flutter#126696.
New backdrop blur playground:
Screen.Recording.2023-05-15.at.5.59.10.AM.mov
Frame capture showing the reduced pass sizes:
Screen.Recording.2023-05-15.at.6.05.21.AM.mov