Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

CP: Migrate Android Engine Debug to Engine V2. (#41687)#41923

Merged
godofredoc merged 1 commit intoflutter:flutter-3.11-candidate.0from
godofredoc:beta_cp_108
May 11, 2023
Merged

CP: Migrate Android Engine Debug to Engine V2. (#41687)#41923
godofredoc merged 1 commit intoflutter:flutter-3.11-candidate.0from
godofredoc:beta_cp_108

Conversation

@godofredoc
Copy link
Contributor

@godofredoc godofredoc commented May 11, 2023

CP: 59c316e

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc
Migrate Android Engine Debug to Engine V2. (#41687)
22615cd 
Legacy and engine v2 builds artifacts are identical. This PR is moving the legacy build to staging and starts uploading engine v2 artifacts to production.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
@godofredoc godofredoc requested a review from XilaiZhang May 11, 2023 02:16
@godofredoc godofredoc mentioned this pull request May 11, 2023
Closed
XilaiZhang
XilaiZhang approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@XilaiZhang XilaiZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

images (1)

@godofredoc godofredoc merged commit 0c7fba4 into flutter:flutter-3.11-candidate.0 May 11, 2023
@godofredoc godofredoc deleted the beta_cp_108 branch May 11, 2023 03:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@XilaiZhang XilaiZhang XilaiZhang approved these changes

@fluttergithubbot fluttergithubbot fluttergithubbot approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@godofredoc @XilaiZhang @fluttergithubbot