[Experiment] Convert AccessibilityFeatures to enum#40863
[Experiment] Convert AccessibilityFeatures to enum#40863bernaferrari wants to merge 1 commit intoflutter:mainfrom bernaferrari:AccessibilityFeatures
AccessibilityFeatures to enum#40863Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
This is confusing, theoretically it could be possible, but the class is weird. It is used as an enum, but its parents (EngineAccessibilityFeaturesBuilder) are used "correctly". Yet, |
AccessibilityFeatures to enumAccessibilityFeatures to enum
Kind of surprising, but part of #40567.
There is a test there that applies to this, and even though I can duplicate the test and fix for SemanticsAction, if this is used as an enum, it can be an enum.
Right? Let's see if tests pass.