This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fail the run_suite_step if any test failures are detected.#40834
Merged
eyebrowsoffire merged 13 commits intomainfrom Apr 4, 2023
Merged
Fail the run_suite_step if any test failures are detected.#40834eyebrowsoffire merged 13 commits intomainfrom
eyebrowsoffire merged 13 commits intomainfrom
Conversation
yjbanov
approved these changes
Apr 1, 2023
| if (io.exitCode != 0) { | ||
| print('[${suite.name.ansiCyan}] ${'Some tests failed.'.ansiRed}'); | ||
| io.exitCode = 0; | ||
| throw ToolExit('Some unit tests failed in suite ${suite.name.ansiCyan}.'); |
Contributor
There was a problem hiding this comment.
Do we need the previous line? It would be good to have a comment explaining why. It's not obvious why exitCode is set to 0 just before throwing an error, which presumably will result in a non-zero exitCode again.
Contributor
Author
There was a problem hiding this comment.
It's basically because we're calling "main" of the test runner, which modifies the exit code. We aggregate all the results and then at the end do our own logic on how to exit the program. I'll add a comment.
Contributor
|
auto label is removed for flutter/engine, pr: 40834, due to - The status or check suite Linux linux_web_engine has failed. Please fix the issues identified (or deflake) before re-applying this label. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 4, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 4, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to throw if the
run_suite_stepencounters any test failures.