This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Android] Fix initial route when app launched by deeplink and not in background#40119
Closed
camsim99 wants to merge 1 commit intoflutter:mainfrom
Closed
[Android] Fix initial route when app launched by deeplink and not in background#40119camsim99 wants to merge 1 commit intoflutter:mainfrom
camsim99 wants to merge 1 commit intoflutter:mainfrom
Conversation
reidbaker
approved these changes
Mar 8, 2023
8 tasks
gaaclarke
suggested changes
Mar 8, 2023
Member
gaaclarke
left a comment
There was a problem hiding this comment.
I chatted with @camsim99 and one of our customers who was helping us debug this issue. I think the solution we want here is in #40148. I don't believe there is a reason to have both PR's. This fixes the issue but is a bit more distant to the source of the problem, pushing the route instead of starting the engine with the route. Let me know if there is anything I'm missing.
Contributor
Author
|
Since I agree with @gaaclarke and the other fix has been verified, I'm going to go ahead and close this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an additional push of the initial route to the framework once the first Flutter frame has been rendered if it has not already been pushed.
This will catch the case of an app being launched by a deeplink that was not previously in the background, because when the app is not previously in the background, no call to push the correct initial route is currently being made and we must wait to push it after the
FlutterActivityhas been created, started, and resumed (in terms of theActivitylifecycle).Fixes flutter/flutter#121244.
Pre-launch Checklist
///).