This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Conversation
Missed in #39133
jmagman
approved these changes
Jan 31, 2023
Member
Author
|
Merging on red to green the tree. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 31, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 31, 2023
* 707458b Roll Dart SDK from 52dc94238144 to c64a3f0c9fea (5 revisions) (flutter/engine#39281) * 0aec06a Roll Dart SDK from c64a3f0c9fea to 4fdbc7c28141 (1 revision) (flutter/engine#39282) * 95a65fc Roll Fuchsia Mac SDK from CNkyuFjzxZhOxLNRS... to IdMSzll1VeWJMV6v8... (flutter/engine#39283) * 9574129 Python compatibility fix (flutter/engine#39286) * 3147334 Roll Skia from 3c6eb76a683a to c29211525dac (2 revisions) (flutter/engine#39289) * cd2e888 Roll Fuchsia Linux SDK from cTwkXiHcuqwrumaJ5... to 71lEeibIyrq0V8jId... (flutter/engine#39284)
godofredoc
added a commit
that referenced
this pull request
Feb 8, 2023
godofredoc
added a commit
that referenced
this pull request
Apr 11, 2023
CP: 9574129 Missed in #39133 ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [X] I listed at least one issue that this PR fixes in the description above. - [X] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on writing and running engine tests. - [X] I updated/added relevant documentation (doc comments with `///`). - [X] I signed the [CLA]. - [X] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missed in #39133
The tree is closed on this here https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20Fuchsia/18752/overview