This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Windows] Use 'FlutterWindowsEngineBuilder' in keyboard unit tests#39209
Merged
auto-submit[bot] merged 4 commits intoflutter:mainfrom Jan 30, 2023
Merged
Conversation
b59b8ea to
ddb41c5
Compare
yaakovschectman
approved these changes
Jan 30, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 31, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 31, 2023
* 033514b [Windows] Remove dead code from FlutterWindow tests (flutter/engine#39216) * daa8eeb [Windows] Use 'FlutterWindowsEngineBuilder' in keyboard unit tests (flutter/engine#39209)
cbracken
reviewed
Feb 1, 2023
Member
cbracken
left a comment
There was a problem hiding this comment.
Missed this earlier but a very hearty LGTM! Love it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the Windows keyboard tests use the new
FlutterWindowsEngineBuilderto create an engine to test against. This will make testing easier when the keyboard & text plugins are moved up from the view to the engine.Part of flutter/flutter#115611
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.