Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[CP] [Impeller] Use DrawPath instead of Rect geometry when the paint style is stroke#38153

Merged
itsjustkevin merged 1 commit intoflutter:flutter-3.7-candidate.1from
zanderso:impeller-stroke-cp
Dec 16, 2022
Merged

[CP] [Impeller] Use DrawPath instead of Rect geometry when the paint style is stroke#38153
itsjustkevin merged 1 commit intoflutter:flutter-3.7-candidate.1from
zanderso:impeller-stroke-cp

Conversation

@zanderso
Copy link
Member

@zanderso zanderso commented Dec 9, 2022

This is the CP PR for #38146. See gskinnerTeam/flutter-wonderous-app#53

@google-cla
Copy link

google-cla bot commented Dec 9, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@zanderso zanderso changed the base branch from main to flutter-3.7-candidate.1 December 9, 2022 16:20
@zanderso
Copy link
Member Author

zanderso commented Dec 9, 2022

The failing CLA is due to the PR not initially targeting the correct branch.

@zanderso zanderso mentioned this pull request Dec 9, 2022
Closed
jonahwilliams
jonahwilliams approved these changes Dec 9, 2022
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zanderso
Copy link
Member Author

zanderso commented Dec 9, 2022 •
edited
Loading

@godofredoc the engine_v2 mac build is failing due to the removal of autoninja? Is the wrong recipe version being used?

@godofredoc
Copy link
Contributor

godofredoc commented Dec 9, 2022

@godofredoc the engine_v2 mac build is failing due to the removal of autoninja? Is the wrong recipe version being used?

@godofredoc the engine_v2 mac build is failing due to the removal of autoninja? Is the wrong recipe version being used?

v2_logic is fully encapsulated in the engine tree and it is failing because autoninja is removed from depot_tools. We'll need to cherry pick #38136 too.

@bdero @zanderso
[Impeller] Use DrawPath instead of Rect geometry when the paint style…
608e346 
… is stroke (flutter#38146)

* [Impeller] Use DrawPath instead of Rect geometry when the paint state is set to stroke

* Add playground
@zanderso zanderso changed the title [Impeller] Use DrawPath instead of Rect geometry when the paint style is stroke [CP] [Impeller] Use DrawPath instead of Rect geometry when the paint style is stroke Dec 13, 2022
@itsjustkevin itsjustkevin merged commit caeae4c into flutter:flutter-3.7-candidate.1 Dec 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bdero bdero Awaiting requested review from bdero

1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@zanderso zanderso

Labels

e: impeller platform-android platform-ios

Projects

No open projects
Impeller
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@zanderso @godofredoc @jonahwilliams @chinmaygarde @itsjustkevin @bdero