This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Refactor ColorSource resolution to use explicit factory types#37656
Merged
bdero merged 1 commit intoflutter:mainfrom Nov 16, 2022
Merged
[Impeller] Refactor ColorSource resolution to use explicit factory types#37656bdero merged 1 commit intoflutter:mainfrom
bdero merged 1 commit intoflutter:mainfrom
Conversation
39d6fe7 to
ccbca74
Compare
ccbca74 to
0325408
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 16, 2022
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 16, 2022
* 8e86071 Roll Skia from cdf8348e6fba to 36efebf14ad8 (4 revisions) (flutter/engine#37665) * 0241f18 [Impeller] Refactor color source resolution to use explicit factory types (flutter/engine#37656)
schwa423
pushed a commit
to schwa423/engine
that referenced
this pull request
Nov 16, 2022
bdero
added a commit
to bdero/flutter-engine
that referenced
this pull request
Nov 16, 2022
…actory types (flutter#37656)" (flutter#37673) This reverts commit d721647.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 16, 2022
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 16, 2022
* 8e86071 Roll Skia from cdf8348e6fba to 36efebf14ad8 (4 revisions) (flutter/engine#37665) * 0241f18 [Impeller] Refactor color source resolution to use explicit factory types (flutter/engine#37656) * 76e8a9c Roll Fuchsia Mac SDK from gKyvwhUS3r6pTRfxx... to uhjeOxDSb9z-mNpGS... (flutter/engine#37667) * 223e1f0 Roll Skia from 36efebf14ad8 to 4b3d36f36bf3 (1 revision) (flutter/engine#37668)
shogohida
pushed a commit
to shogohida/flutter
that referenced
this pull request
Dec 7, 2022
…5423) * 8e86071 Roll Skia from cdf8348e6fba to 36efebf14ad8 (4 revisions) (flutter/engine#37665) * 0241f18 [Impeller] Refactor color source resolution to use explicit factory types (flutter/engine#37656)
shogohida
pushed a commit
to shogohida/flutter
that referenced
this pull request
Dec 7, 2022
…5463) * 8e86071 Roll Skia from cdf8348e6fba to 36efebf14ad8 (4 revisions) (flutter/engine#37665) * 0241f18 [Impeller] Refactor color source resolution to use explicit factory types (flutter/engine#37656) * 76e8a9c Roll Fuchsia Mac SDK from gKyvwhUS3r6pTRfxx... to uhjeOxDSb9z-mNpGS... (flutter/engine#37667) * 223e1f0 Roll Skia from 36efebf14ad8 to 4b3d36f36bf3 (1 revision) (flutter/engine#37668)
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…5423) * 8e86071 Roll Skia from cdf8348e6fba to 36efebf14ad8 (4 revisions) (flutter/engine#37665) * 0241f18 [Impeller] Refactor color source resolution to use explicit factory types (flutter/engine#37656)
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…5463) * 8e86071 Roll Skia from cdf8348e6fba to 36efebf14ad8 (4 revisions) (flutter/engine#37665) * 0241f18 [Impeller] Refactor color source resolution to use explicit factory types (flutter/engine#37656) * 76e8a9c Roll Fuchsia Mac SDK from gKyvwhUS3r6pTRfxx... to uhjeOxDSb9z-mNpGS... (flutter/engine#37667) * 223e1f0 Roll Skia from 36efebf14ad8 to 4b3d36f36bf3 (1 revision) (flutter/engine#37668)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This couples the type enum and resolution logic for color sources into explicit factories with the intention of making ColorSource-related bugs easier to avoid.
setColorSourcefanout easier to navigate.