This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Multiwindow] Backing store and compositor#36452
Closed
dkwingsmt wants to merge 14 commits intoflutter:mainfrom
Closed
[Multiwindow] Backing store and compositor#36452dkwingsmt wants to merge 14 commits intoflutter:mainfrom
dkwingsmt wants to merge 14 commits intoflutter:mainfrom
Conversation
7cb5d5a to
fce69d0
Compare
fce69d0 to
6155d81
Compare
Contributor
Author
|
Closed in favor for #37391. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is based on #36392 and currently contains parent PRs . See dkwingsmt#8 for net changes.
This PR turns backing store and compositor to fitting the multi-view world. The change stops at:
Rasterizer::SubmitFrame, where it will expect a view ID fromLayerTreebut uses a fake one for now.macos/FlutterEngine, where it should pick aviewControllerbased on surface ID, but it only has one view controller for now.This PR makes non-trivial changes to the embedder API:
AddRenderSurface.FlutterCompositor.present_layers_callback, addsFlutterCompositor.present_layers_view_callback.FlutterBackingStoreConfig.view_id.Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.