This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Conversation
The MockBinaryMessenger tweaks applied by flutter#33955 caused the newly added tests in flutter#33313 to not build.
zanderso
approved these changes
Jun 27, 2022
Member
|
Landing on red to green the tree. |
Member
Author
|
It's back to green. My apologies for the break! |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a) #33955 and #33313 did not conform to the new clang-tidy rules enabled in #33692: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8810225690269242849/+/u/test:_lint_host_debug/stdout
b) MockBinaryMessenger tweaks applied by #33955 caused the newly added tests in #33313 to not build: https://github.com/flutter/engine/runs/7063741502