This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Add high DPI support to the ImGui Impeller backend; make high DPI work in the Metal playground; make playground tests respect content scale#33708
Merged
bdero merged 7 commits intoflutter:mainfrom May 31, 2022
Conversation
a4dc723 to
d2dd579
Compare
dnfield
approved these changes
May 31, 2022
d2dd579 to
b6d9110
Compare
chinmaygarde
approved these changes
May 31, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 31, 2022
…; make high DPI work in the Metal playground; make playground tests respect content scale (flutter/engine#33708)
Contributor
|
Fixes flutter/flutter#104863 |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 31, 2022
…; make high DPI work in the Metal playground; make playground tests respect content scale (flutter/engine#33708)
houhuayong
pushed a commit
to houhuayong/engine
that referenced
this pull request
Jun 21, 2022
…igh DPI work in the Metal playground; make playground tests respect content scale (flutter#33708)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #33706.
imgui_impl_glfwalready set it correctly, so there's no need for extra params on e.g.ImGui_ImplImpeller_RenderDrawData(). :)