Windows: Fix regression introduced by eliminating use of OpenGL ES 3.1 symbols#33195
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
shouldn't this be tested? |
I‘m not sure. So we might need more sophisticated tests actually spinning up the engine and making it use a texture to see if Skia accepts it. |
Fixes flutter/flutter#102925
This fixes a regression introduced in #32780 (by changing
GL_RGBA8to an unsizedGL_RGBA).Pre-launch Checklist
writing and running engine tests.
///).