Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Roll libpng to 134cf139cb24d802ee6ad5fc51bccff3221c2b49#32688

Merged
cbracken merged 1 commit intoflutter:mainfrom
cbracken:roll-libpng
Apr 14, 2022
Merged

Roll libpng to 134cf139cb24d802ee6ad5fc51bccff3221c2b49#32688
cbracken merged 1 commit intoflutter:mainfrom
cbracken:roll-libpng

Conversation

@cbracken
Copy link
Member

@cbracken cbracken commented Apr 14, 2022 •
edited
Loading

Includes:

Issue: flutter/flutter#59199

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@cbracken
Roll libpng to 134cf139cb24d802ee6ad5fc51bccff3221c2b49
67a589b 
Includes:
* Win32: Suppress tautological const compare warning

Issue: flutter/flutter#59199
gspencergoog
gspencergoog approved these changes Apr 14, 2022
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@cbracken cbracken added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Apr 14, 2022
@cbracken cbracken merged commit 0c1fd9d into flutter:main Apr 14, 2022
@cbracken cbracken deleted the roll-libpng branch April 14, 2022 22:37
@cbracken cbracken mentioned this pull request Apr 14, 2022
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 15, 2022
@engine-flutter-autoroll
0c1fd9d Roll libpng to 134cf139cb24d802ee6ad5fc51bccff3221c2b49 (flut…
239bdca 
…ter/engine#32688)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 15, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 15, 2022
@engine-flutter-autoroll
0c1fd9d Roll libpng to 134cf139cb24d802ee6ad5fc51bccff3221c2b49 (flut…
5e6d3c0 
…ter/engine#32688)
justinmc pushed a commit to justinmc/engine that referenced this pull request Apr 20, 2022
@cbracken @justinmc
Roll libpng to 134cf139cb24d802ee6ad5fc51bccff3221c2b49 (flutter#32688)
313ec3a 
Includes:
* Win32: Suppress tautological const compare warning

Issue: flutter/flutter#59199
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jason-simmons jason-simmons Awaiting requested review from jason-simmons

1 more reviewer

@gspencergoog gspencergoog gspencergoog approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cbracken @gspencergoog

Comments