This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
Build CanvasKit in the Flutter Engine #32510
Merged
harryterkelsen
merged 57 commits into
flutter:main
from
harryterkelsen:crosscompile-wasm
Sep 14, 2022
Merged
Changes from all commits
Commits
Show all changes
57 commits
Select commit
Hold shift + click to select a range
4c70893
Update ICU and license checks
harryterkelsen a7dd7f9
Build CanvasKit using cross-compilation as part of the Web SDK build
harryterkelsen 5ec414b
Merge branch 'main' into crosscompile-wasm
harryterkelsen 7de9a6b
Update GN for flutter_web_sdk
harryterkelsen 4ae3584
gn format
harryterkelsen 9225fe8
Merge branch 'main' into crosscompile-wasm
harryterkelsen ae79d17
Undo changes to licenses
harryterkelsen fbd145c
Merge branch 'main' into crosscompile-wasm
harryterkelsen da0a929
Merge branch 'main' into crosscompile-wasm
harryterkelsen 7255b6d
Fix merge conflict
harryterkelsen 8fdba5f
Merge branch 'main' into crosscompile-wasm
harryterkelsen 92fe4ca
Merge branch 'main' into crosscompile-wasm
harryterkelsen 5e150c5
WIP update ICU dep and add stamp file for recipes
harryterkelsen b2edf99
Update .ci.yaml with gclient custom vars
harryterkelsen e43a467
Put boolean in quotes to try to appease json decoder
harryterkelsen 8623343
Revert "Revert "Update ICU to 71-1 (#32879)" (#33274)"
harryterkelsen 0f50af0
Update licenses
harryterkelsen d29d199
Try to fix format of ci.yaml
harryterkelsen e0ccb57
Remove hostDebugUnoptDir since it's not used in the web build
harryterkelsen 1ca5973
Update dart-sdk dir
harryterkelsen def1ed8
Update analysis script
harryterkelsen 8794719
typo
harryterkelsen dc67639
Merge branch 'main' into crosscompile-wasm
harryterkelsen 7ca592b
Update to latest main
harryterkelsen 80b6e04
pyformat
harryterkelsen 3f98442
fix formatting
harryterkelsen 05a7f8f
Merge branch 'main' into crosscompile-wasm
harryterkelsen 0709ea7
WIP
harryterkelsen f7fbcd0
Merge branch 'main' into crosscompile-wasm
harryterkelsen 6309a4b
Cross-compile CanvasKit as part of the normal build
harryterkelsen 2510896
Format gn
harryterkelsen 6a8cdfa
Fix formatting
harryterkelsen b845f65
Merge branch 'main' into crosscompile-wasm
harryterkelsen 3b15d6f
Rename toolchain
harryterkelsen 8452fac
Revert bad merge
harryterkelsen 4eee7a3
Format
harryterkelsen e003d5e
Merge branch 'main' into crosscompile-wasm
harryterkelsen 7ade9fc
Fix merge
harryterkelsen 662d022
Fix merge more
harryterkelsen 719ae93
More cleanups
harryterkelsen 215dad0
Clean up BUILD.gn
harryterkelsen f6a8e39
Format
harryterkelsen f3e6ec4
Fix up build
harryterkelsen 1df1ca1
Fix bad name
harryterkelsen e1e7f58
Merge branch 'main' into crosscompile-wasm
harryterkelsen e002743
Undo bad merge
harryterkelsen d8e71d0
touchup bad merge
harryterkelsen 5aac869
more merge
harryterkelsen 7840983
Start to convert to building CanvasKit separately as part of a WASM
harryterkelsen ea79185
Refactor to build CanvasKit into out/wasm_debug
harryterkelsen a2105ca
Fix formatting
harryterkelsen 155be8a
Merge branch 'main' into crosscompile-wasm
harryterkelsen b5bddae
Build CanvasKit in release mode for codesize
harryterkelsen 90c183b
Roll buildroot
harryterkelsen 3a0bb7d
format fix
harryterkelsen 1d8cb76
Add documentation
harryterkelsen dd84da3
Keep `download_emsdk` to False for now
harryterkelsen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| # Copyright 2022 The Flutter Authors. All rights reserved. | ||
| # Use of this source code is governed by a BSD-style license that can be | ||
| # found in the LICENSE file. | ||
|
|
||
| # This BUILD.gn is kept separate from //flutter/BUILD.gn because | ||
| # //flutter/BUILD.gn pulls in Flutter SDK dependencies which will crash | ||
| # when the target CPU is WASM. | ||
|
|
||
| # This is the default target when building when the target CPU is WASM. | ||
| group("wasm") { | ||
| deps = [ "//third_party/skia/modules/canvaskit" ] | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A comment explaining this function could be useful in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.