This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "Fix Windows external texture interference (#25193)"#25292
Merged
cbracken merged 1 commit intoflutter:masterfrom Mar 29, 2021
cbracken:revert-windows-texture
Merged
Revert "Fix Windows external texture interference (#25193)"#25292cbracken merged 1 commit intoflutter:masterfrom cbracken:revert-windows-texture
cbracken merged 1 commit intoflutter:masterfrom
cbracken:revert-windows-texture
Conversation
This will cause the previous texture binding used by Skia to be
incorrectly unbound, such that should they need to re-used an existing
binding, we'll end up rendering blank instead.
Instead we should be using
context->flushAndSubmit();
context->resetContext(kAll_GrBackendState);
in `EmbedderExternalTextureGL::ResolveTexture` in order to notify Skia
that we've updated handles within the current binding and invalidate any
assumptions about previous modifications it has made to the context.
This reverts commit d6e5946.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
chinmaygarde
approved these changes
Mar 29, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 30, 2021
chandarrengoog
pushed a commit
to chandarrengoog/engine
that referenced
this pull request
Mar 30, 2021
…lutter#25292) This will cause the previous texture binding used by Skia to be incorrectly unbound, such that should they need to re-used an existing binding, we'll end up rendering blank instead. Instead we should be using context->flushAndSubmit(); context->resetContext(kAll_GrBackendState); in `EmbedderExternalTextureGL::ResolveTexture` in order to notify Skia that we've updated handles within the current binding and invalidate any assumptions about previous modifications it has made to the context. This reverts commit d6e5946.
duanqz
pushed a commit
to duanqz/engine
that referenced
this pull request
Apr 16, 2021
…lutter#25292) This will cause the previous texture binding used by Skia to be incorrectly unbound, such that should they need to re-used an existing binding, we'll end up rendering blank instead. Instead we should be using context->flushAndSubmit(); context->resetContext(kAll_GrBackendState); in `EmbedderExternalTextureGL::ResolveTexture` in order to notify Skia that we've updated handles within the current binding and invalidate any assumptions about previous modifications it has made to the context. This reverts commit d6e5946.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will cause the previous texture binding used by Skia to be
incorrectly unbound, such that should they need to re-used an existing
binding, we'll end up rendering blank instead.
Instead we should be using
in
EmbedderExternalTextureGL::ResolveTexturein order to notify Skiathat we've updated handles within the current binding and invalidate any
assumptions about previous modifications it has made to the context.
This reverts commit d6e5946.
Related flutter/flutter#78648
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.