This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "Reland: Use dispatchKeyEventPreIme, and handle keys sent to InputConnection.sendKeyEvent on Android (#22304)"#22321
Merged
gspencergoog merged 1 commit intoflutter:masterfrom Nov 5, 2020
Conversation
…nputConnection.sendKeyEvent on Android (flutter#22304)" This reverts commit 7a8057b because it breaks back button functionality.
zanderso
approved these changes
Nov 5, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 5, 2020
…ent to InputConnection.sendKeyEvent on Android (flutter#22304)" (flutter/engine#22321)
gspencergoog
added a commit
to gspencergoog/engine
that referenced
this pull request
Nov 6, 2020
…ent to InputConnection.sendKeyEvent on Android (flutter#22304)" (flutter#22321)" This reverts commit 5d481fb.
1 task
gspencergoog
added a commit
that referenced
this pull request
Nov 6, 2020
…Event on Android (#22340) This (mostly) re-lands #21163, which was reverted in #22321 This switches from using onKeyDown to using dispatchKeyEvent on Android so that keys can be intercepted handled by the framework and not continue to be dispatched to other controls. It also now intercepts key events sent to InputConnection.sendKeyEvent, as some IMEs do (e.g. the Hacker's Keyboard), and sends them to Flutter. This fixes the problem where (for example) pressing TAB on a hardware keyboard sends the tab to both the text field and to the focus traversal system. Note that we still can't intercept all keystrokes given to a soft keyboard, only those which the soft keyboard decides to send to InputConnection.sendKeyEvent, and system keys (like the back button) are only received if the IME doesn't eat them.
chaselatta
pushed a commit
to chaselatta/engine
that referenced
this pull request
Nov 30, 2020
…nputConnection.sendKeyEvent on Android (flutter#22304)" (flutter#22321) This reverts commit 7a8057b because it breaks back button functionality.
chaselatta
pushed a commit
to chaselatta/engine
that referenced
this pull request
Nov 30, 2020
…Event on Android (flutter#22340) This (mostly) re-lands flutter#21163, which was reverted in flutter#22321 This switches from using onKeyDown to using dispatchKeyEvent on Android so that keys can be intercepted handled by the framework and not continue to be dispatched to other controls. It also now intercepts key events sent to InputConnection.sendKeyEvent, as some IMEs do (e.g. the Hacker's Keyboard), and sends them to Flutter. This fixes the problem where (for example) pressing TAB on a hardware keyboard sends the tab to both the text field and to the focus traversal system. Note that we still can't intercept all keystrokes given to a soft keyboard, only those which the soft keyboard decides to send to InputConnection.sendKeyEvent, and system keys (like the back button) are only received if the IME doesn't eat them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This reverts commit 7a8057b because it breaks back button functionality.
Related Issues
Fixes flutter/flutter#69886