Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Rebuild CkPath on top of @JS bindings with 3.28x speed-up on the path benchmark#19694

Merged
yjbanov merged 4 commits intoflutter:masterfrom
yjbanov:js-path
Jul 14, 2020
Merged

Rebuild CkPath on top of @JS bindings with 3.28x speed-up on the path benchmark#19694
yjbanov merged 4 commits intoflutter:masterfrom
yjbanov:js-path

Conversation

@yjbanov
Copy link
Contributor

@yjbanov yjbanov commented Jul 12, 2020 •
edited
Loading

Description

Rebuild CkPath on top of @JS bindings. This results in 3.28x speed-up on the recordPathConstruction benchmark.

Benchmark A/B results:

Score	Average A (noise)	Average B (noise)	Speed-up
bench_path_recording.canvaskit.recordPathConstruction.average	67912.43 (1.23%)	20725.67 (1.44%)	3.28x
bench_path_recording.canvaskit.recordPathConstruction.outlierRatio	1.06 (1.52%)	1.15 (1.07%)	0.92x

Update: results from the devicelab:

Screen Shot 2020-07-15 at 5 44 21 PM

@yjbanov yjbanov marked this pull request as ready for review July 13, 2020 15:51
@yjbanov yjbanov requested a review from harryterkelsen July 13, 2020 15:51
@auto-assign auto-assign bot requested a review from GaryQian July 13, 2020 15:53
@yjbanov yjbanov changed the title Rebuild CkPath on top of @JS bindings with 2.3x speed-up on the path benchmark Rebuild CkPath on top of @JS bindings with 3.28x speed-up on the path benchmark Jul 13, 2020
harryterkelsen
harryterkelsen approved these changes Jul 13, 2020
View reviewed changes
Copy link
Contributor

@harryterkelsen harryterkelsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo!!

@yjbanov yjbanov merged commit d0b8706 into flutter:master Jul 14, 2020
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 14, 2020
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 14, 2020
@engine-flutter-autoroll
d0b8706 Rebuild CkPath on top of @JS bindings with 3.28x speed-up o…
4eb18ac 
…n the path benchmark (flutter/engine#19694)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@GaryQian GaryQian Awaiting requested review from GaryQian

1 more reviewer

@harryterkelsen harryterkelsen harryterkelsen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yjbanov @harryterkelsen @googlebot