Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Revert "Add a deprecation javadoc note to the old FlutterActivity"#15331

Merged
jmagman merged 1 commit intomasterfrom
revert-15156-fa-dep
Jan 9, 2020
Merged

Revert "Add a deprecation javadoc note to the old FlutterActivity"#15331
jmagman merged 1 commit intomasterfrom
revert-15156-fa-dep

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Jan 9, 2020

Reverts #15156

Integration tests are using deprecated APIs, which is writing to stderr, which is a test failure.

run_machine_concurrent_hot_reload_945f206_2.log

2020-01-08T15:23:22.242402: run:stderr: [+22729 ms] Note: /Users/flutter/.cocoon/flutter/dev/integration_tests/ui/android/app/src/main/java/com/yourcompany/integration_ui/MainActivity.java uses or overrides a deprecated API.2020-01-08T15:23:22.242974: 

@jmagman jmagman self-assigned this Jan 9, 2020
@auto-assign auto-assign bot requested a review from flar January 9, 2020 02:04
@jmagman
Copy link
Member Author

jmagman commented Jan 9, 2020

\cc @xster

Merging to green out the Flutter build.

@jmagman jmagman merged commit 5759a43 into master Jan 9, 2020
@jmagman jmagman deleted the revert-15156-fa-dep branch January 9, 2020 02:04
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 10, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 10, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 10, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 10, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 10, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 10, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 10, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 10, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 11, 2020
NoamDev pushed a commit to NoamDev/engine that referenced this pull request Feb 27, 2020
NoamDev added a commit to NoamDev/engine that referenced this pull request Feb 27, 2020
filmil pushed a commit to filmil/engine that referenced this pull request Mar 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants