Bump google_sign_in_web to resolve dashboard sign in issue#3304
Closed
sealesj wants to merge 1 commit intoflutter:mainfrom
Closed
Bump google_sign_in_web to resolve dashboard sign in issue#3304sealesj wants to merge 1 commit intoflutter:mainfrom
sealesj wants to merge 1 commit intoflutter:mainfrom
Conversation
Member
|
@sealesj please, don't land this, I'm about to publish a PR for 0.12.3 which doesn't break cocoon :) |
Contributor
Author
|
Awesome! Thanks for letting me know |
11 tasks
Member
|
It seems the fixed version is going to be: 0.12.2+1. |
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Dec 2, 2023
When initializing a `CodeClient`, it is mandatory to pass at least one `scope` (or the JS initialization will crash). This PR ensures that the `CodeClient` is not created unless `initialScopes.isNotEmpty`, and lets the user know when attempting to use said client that it hasn't been initialized properly. ## Issues * Fixes: flutter/flutter#139382 * Fixes: flutter/flutter#62474 * Closes: flutter/cocoon#3304 (makes this PR unneeded) ## Tests * Tested locally with `cocoon`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to resolve the dashboard sign-in issue, bump google_sign_in_web to 0.12.1
List which issues are fixed by this PR. You must list at least one issue.
Resolves: flutter/flutter#139382
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.