Merged
Conversation
Adds a bunch of samples for FontFeature.
Hixie
added a commit
to Hixie/sky_engine
that referenced
this pull request
Jan 16, 2021
This adds support and documentation for: * FontFeature.alternative(n) * FontFeature.alternativeFractions() * FontFeature.contextualAlternates() * FontFeature.caseSensitiveForms() * FontFeature.characterVariant(v) * FontFeature.denominator() * FontFeature.fractions() * FontFeature.historicalForms() * FontFeature.historicalLigatures() * FontFeature.liningFigures() * FontFeature.localeAware(enable: false) * FontFeature.notationalForms(v) * FontFeature.numerators() * FontFeature.oldstyleFigures() * FontFeature.ordinalForms() * FontFeature.proportionalFigures() * FontFeature.randomize() (minor additions to documentation) * FontFeature.stylisticAlternates() * FontFeature.scientificInferiors() * FontFeature.stylisticSet(n) (documentation) * FontFeature.subscripts() * FontFeature.superscripts() * FontFeature.swash(v) * FontFeature.tabularFigures() (documentation) * FontFeature.slashedZero() There's hundreds more we could add but this is what I have so far. See flutter/assets-for-api-docs#131 for the diagrams.
Contributor
Author
|
See flutter/engine#23730 for what these document. |
Contributor
Author
|
cc @GaryQian |
Hixie
added a commit
to Hixie/sky_engine
that referenced
this pull request
Jan 19, 2021
This adds support and documentation for: * FontFeature.alternative(n) * FontFeature.alternativeFractions() * FontFeature.contextualAlternates() * FontFeature.caseSensitiveForms() * FontFeature.characterVariant(v) * FontFeature.denominator() * FontFeature.fractions() * FontFeature.historicalForms() * FontFeature.historicalLigatures() * FontFeature.liningFigures() * FontFeature.localeAware(enable: false) * FontFeature.notationalForms(v) * FontFeature.numerators() * FontFeature.oldstyleFigures() * FontFeature.ordinalForms() * FontFeature.proportionalFigures() * FontFeature.randomize() (minor additions to documentation) * FontFeature.stylisticAlternates() * FontFeature.scientificInferiors() * FontFeature.stylisticSet(n) (documentation) * FontFeature.subscripts() * FontFeature.superscripts() * FontFeature.swash(v) * FontFeature.tabularFigures() (documentation) * FontFeature.slashedZero() There's hundreds more we could add but this is what I have so far. See flutter/assets-for-api-docs#131 for the diagrams.
Hixie
added a commit
to Hixie/sky_engine
that referenced
this pull request
Jan 20, 2021
This adds support and documentation for: * FontFeature.alternative(n) * FontFeature.alternativeFractions() * FontFeature.contextualAlternates() * FontFeature.caseSensitiveForms() * FontFeature.characterVariant(v) * FontFeature.denominator() * FontFeature.fractions() * FontFeature.historicalForms() * FontFeature.historicalLigatures() * FontFeature.liningFigures() * FontFeature.localeAware(enable: false) * FontFeature.notationalForms(v) * FontFeature.numerators() * FontFeature.oldstyleFigures() * FontFeature.ordinalForms() * FontFeature.proportionalFigures() * FontFeature.randomize() (minor additions to documentation) * FontFeature.stylisticAlternates() * FontFeature.scientificInferiors() * FontFeature.stylisticSet(n) (documentation) * FontFeature.subscripts() * FontFeature.superscripts() * FontFeature.swash(v) * FontFeature.tabularFigures() (documentation) * FontFeature.slashedZero() There's hundreds more we could add but this is what I have so far. See flutter/assets-for-api-docs#131 for the diagrams.
GaryQian
reviewed
Jan 21, 2021
| final List<String> categories = flags['category'] as List<String>; | ||
| final List<String> names = flags['name'] as List<String>; | ||
|
|
||
| print('Filters:\n categories: $categories\n names: $names'); |
Contributor
There was a problem hiding this comment.
Nit: Was this meant to be for debug or actually included here?
Contributor
Author
There was a problem hiding this comment.
It was intended to stay. The generator is really only run by us, so it's useful to see what it's doing. Previously we didn't report what filters we applied. (This is especially helpful on Linux where we don't currently handle arguments so the filters you specify on the command line don't actually apply and previously that was very confusing.)
GaryQian
reviewed
Jan 21, 2021
|
|
||
| - family: Ubuntu Mono | ||
| fonts: | ||
| - asset: fonts/UbuntuMono-Bold.ttf |
GaryQian
approved these changes
Jan 21, 2021
Contributor
GaryQian
left a comment
There was a problem hiding this comment.
LGTM, looks really comprehensive!
Contributor
Author
|
Thanks, will land on green. |
Hixie
added a commit
to Hixie/sky_engine
that referenced
this pull request
Jan 21, 2021
This adds support and documentation for: * FontFeature.alternative(n) * FontFeature.alternativeFractions() * FontFeature.contextualAlternates() * FontFeature.caseSensitiveForms() * FontFeature.characterVariant(v) * FontFeature.denominator() * FontFeature.fractions() * FontFeature.historicalForms() * FontFeature.historicalLigatures() * FontFeature.liningFigures() * FontFeature.localeAware(enable: false) * FontFeature.notationalForms(v) * FontFeature.numerators() * FontFeature.oldstyleFigures() * FontFeature.ordinalForms() * FontFeature.proportionalFigures() * FontFeature.randomize() (minor additions to documentation) * FontFeature.stylisticAlternates() * FontFeature.scientificInferiors() * FontFeature.stylisticSet(n) (documentation) * FontFeature.subscripts() * FontFeature.superscripts() * FontFeature.swash(v) * FontFeature.tabularFigures() (documentation) * FontFeature.slashedZero() There's hundreds more we could add but this is what I have so far. See flutter/assets-for-api-docs#131 for the diagrams.
Hixie
added a commit
to Hixie/sky_engine
that referenced
this pull request
Jan 21, 2021
This adds support and documentation for: * FontFeature.alternative(n) * FontFeature.alternativeFractions() * FontFeature.contextualAlternates() * FontFeature.caseSensitiveForms() * FontFeature.characterVariant(v) * FontFeature.denominator() * FontFeature.fractions() * FontFeature.historicalForms() * FontFeature.historicalLigatures() * FontFeature.liningFigures() * FontFeature.localeAware(enable: false) * FontFeature.notationalForms(v) * FontFeature.numerators() * FontFeature.oldstyleFigures() * FontFeature.ordinalForms() * FontFeature.proportionalFigures() * FontFeature.randomize() (minor additions to documentation) * FontFeature.stylisticAlternates() * FontFeature.scientificInferiors() * FontFeature.stylisticSet(n) (documentation) * FontFeature.subscripts() * FontFeature.superscripts() * FontFeature.swash(v) * FontFeature.tabularFigures() (documentation) * FontFeature.slashedZero() There's hundreds more we could add but this is what I have so far. See flutter/assets-for-api-docs#131 for the diagrams.
Hixie
added a commit
to Hixie/sky_engine
that referenced
this pull request
Jan 24, 2021
This adds support and documentation for: * FontFeature.alternative(n) * FontFeature.alternativeFractions() * FontFeature.contextualAlternates() * FontFeature.caseSensitiveForms() * FontFeature.characterVariant(v) * FontFeature.denominator() * FontFeature.fractions() * FontFeature.historicalForms() * FontFeature.historicalLigatures() * FontFeature.liningFigures() * FontFeature.localeAware(enable: false) * FontFeature.notationalForms(v) * FontFeature.numerators() * FontFeature.oldstyleFigures() * FontFeature.ordinalForms() * FontFeature.proportionalFigures() * FontFeature.randomize() (minor additions to documentation) * FontFeature.stylisticAlternates() * FontFeature.scientificInferiors() * FontFeature.stylisticSet(n) (documentation) * FontFeature.subscripts() * FontFeature.superscripts() * FontFeature.swash(v) * FontFeature.tabularFigures() (documentation) * FontFeature.slashedZero() There's hundreds more we could add but this is what I have so far. See flutter/assets-for-api-docs#131 for the diagrams.
Hixie
added a commit
to Hixie/sky_engine
that referenced
this pull request
Jan 26, 2021
This adds support and documentation for: * FontFeature.alternative(n) * FontFeature.alternativeFractions() * FontFeature.contextualAlternates() * FontFeature.caseSensitiveForms() * FontFeature.characterVariant(v) * FontFeature.denominator() * FontFeature.fractions() * FontFeature.historicalForms() * FontFeature.historicalLigatures() * FontFeature.liningFigures() * FontFeature.localeAware(enable: false) * FontFeature.notationalForms(v) * FontFeature.numerators() * FontFeature.oldstyleFigures() * FontFeature.ordinalForms() * FontFeature.proportionalFigures() * FontFeature.randomize() (minor additions to documentation) * FontFeature.stylisticAlternates() * FontFeature.scientificInferiors() * FontFeature.stylisticSet(n) (documentation) * FontFeature.subscripts() * FontFeature.superscripts() * FontFeature.swash(v) * FontFeature.tabularFigures() (documentation) * FontFeature.slashedZero() There's hundreds more we could add but this is what I have so far. See flutter/assets-for-api-docs#131 for the diagrams.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a bunch of samples for FontFeature.