Refactor the logger#144
Conversation
bwikbs
left a comment
There was a problem hiding this comment.
I like old style(printf-like) better.. but It looks like much more trendy code! 😄
|
@bwikbs I also find the printf-style logs are more readable and easy to format in some cases, but the stream style has some benefits as explained in the Google style guide.
I guess the portability here means the need to use format specifiers like |
|
@swift-kim 👍 I can't say a word.. |
|
@bbrto21 I changed the log level of some messages in |
- Replace __FILE__ with __MODULE__. - Resolve unused variable warning: kLogTag. - Typo fix and etc.
* Rewrite tizen_log in the C++ style * Convert logs to streams * Rename tizen_log to logger * Misc fixes - Replace __FILE__ with __MODULE__. - Resolve unused variable warning: kLogTag. - Typo fix and etc. * Change min logging level to Debug when --verbose-logging is set * Resolve conflicts & additional clean-up * Resolve conflicts again
* Rewrite tizen_log in the C++ style * Convert logs to streams * Rename tizen_log to logger * Misc fixes - Replace __FILE__ with __MODULE__. - Resolve unused variable warning: kLogTag. - Typo fix and etc. * Change min logging level to Debug when --verbose-logging is set * Resolve conflicts & additional clean-up * Resolve conflicts again
* Rewrite tizen_log in the C++ style * Convert logs to streams * Rename tizen_log to logger * Misc fixes - Replace __FILE__ with __MODULE__. - Resolve unused variable warning: kLogTag. - Typo fix and etc. * Change min logging level to Debug when --verbose-logging is set * Resolve conflicts & additional clean-up * Resolve conflicts again
* Rewrite tizen_log in the C++ style * Convert logs to streams * Rename tizen_log to logger * Change min logging level to Debug when --verbose-logging is set * Resolve conflicts & additional clean-up
* Rewrite tizen_log in the C++ style * Convert logs to streams * Rename tizen_log to logger * Change min logging level to Debug when --verbose-logging is set * Resolve conflicts & additional clean-up
* Rewrite tizen_log in the C++ style * Convert logs to streams * Rename tizen_log to logger * Change min logging level to Debug when --verbose-logging is set * Resolve conflicts & additional clean-up
* Rewrite tizen_log in the C++ style * Convert logs to streams * Rename tizen_log to logger * Change min logging level to Debug when --verbose-logging is set * Resolve conflicts & additional clean-up
* Rewrite tizen_log in the C++ style * Convert logs to streams * Rename tizen_log to logger * Change min logging level to Debug when --verbose-logging is set * Resolve conflicts & additional clean-up
* Rewrite tizen_log in the C++ style * Convert logs to streams * Rename tizen_log to logger * Change min logging level to Debug when --verbose-logging is set * Resolve conflicts & additional clean-up
Logger,LogMessage.FT_LOGE→FT_LOG(Error).FT_RELEASE_ASSERT,FT_COMPILE_ASSERT).tizen_log.ccandtizen_log_stub.ccinto one file.tizen_log.htologger.h.--verbose-system-logsoption by fixing typo in the arg name (verbose-logging→--verbose-logging).Sorry for another large commit. The change couldn't be divided into smaller commits.