Refactor TextInputChannel#142
Merged
swift-kim merged 6 commits intoflutter-tizen:flutter-2.2.1-tizenfrom Jul 15, 2021
Merged
Conversation
* Introduce TizenInputMethodContext * Do not handle key event for PlatformView in TextInputChannel Each PlatformView must Implement to handle key event. After this patch, the input panel of webview_flutter does not work properly. but it have to handle every key event on itself like webview_flutter_ewk does. Signed-off-by: Boram Bae <[email protected]>
Member
void DispatchCompositionUpdateEvent(const std::string& key);
void DispatchCompositionEndEvent(const std::string& key);Is this intentional? Shouldn't we remove this? |
Author
Yes, the text composition of the |
Member
|
If we don't need it, how about removing it this time? We need a engine release because of the platformview interface change , so let's do it together. |
Author
I will remove it immediately. |
swift-kim
reviewed
Jul 14, 2021
Comment on lines
46
to
51
| if (engine->text_input_channel) { | ||
| if (is_down) { | ||
| if (is_down && engine->text_input_channel->IsSoftwareKeyboardShowing()) { | ||
| engine->text_input_channel->OnKeyDown(key); | ||
| } | ||
| if (engine->text_input_channel->IsSoftwareKeyboardShowing()) { | ||
| return ECORE_CALLBACK_PASS_ON; | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
The text input channel only handles the key event when the software keyboard is shown?
Author
There was a problem hiding this comment.
Well... strictly, I should say no, If the TextInputModel is valid, it can handle key-event.
It is created when TextInputChannel receives TextInput.setClient as a message.
(The message for showing the keyboard is TextInput.show.)
Member
There was a problem hiding this comment.
Mmmm. You have to carefully see how the original logic looks like. It skips sending a key event to key_event_channel only when the software keyboard is shown.
Author
There was a problem hiding this comment.
I think... it's changed a bit, but the behavior hasn't changed much.
Signed-off-by: Boram Bae <[email protected]>
Signed-off-by: Boram Bae <[email protected]>
* Use SendKeyEvent as the method name for handling key events like others. * SendKeyEvent returns true if the key event has been handled. Signed-off-by: Boram Bae <[email protected]>
Author
@bwikbs |
bwikbs
approved these changes
Jul 14, 2021
Member
bwikbs
left a comment
There was a problem hiding this comment.
Please, review again
Thanks! 👍
swift-kim
reviewed
Jul 15, 2021
Signed-off-by: Boram Bae <[email protected]>
Signed-off-by: Boram Bae <[email protected]>
swift-kim
approved these changes
Jul 15, 2021
swift-kim
pushed a commit
that referenced
this pull request
Sep 27, 2021
* Refactor TextInputChannel * Introduce TizenInputMethodContext * Do not handle key event for PlatformView in TextInputChannel Each PlatformView must Implement to handle key event. After this patch, the input panel of webview_flutter does not work properly. but it have to handle every key event on itself like webview_flutter_ewk does. Signed-off-by: Boram Bae <[email protected]> * Remove unnecessary PlatformView APIs Signed-off-by: Boram Bae <[email protected]> * Tidy up based on review Signed-off-by: Boram Bae <[email protected]> * Always Send key event to TextInputChannel * Use SendKeyEvent as the method name for handling key events like others. * SendKeyEvent returns true if the key event has been handled. Signed-off-by: Boram Bae <[email protected]> * Use #if defined() instead of #ifdef Signed-off-by: Boram Bae <[email protected]> * Rename to ShouldNotFilterEvent Signed-off-by: Boram Bae <[email protected]>
swift-kim
pushed a commit
that referenced
this pull request
Nov 14, 2021
* Refactor TextInputChannel * Introduce TizenInputMethodContext * Do not handle key event for PlatformView in TextInputChannel Each PlatformView must Implement to handle key event. After this patch, the input panel of webview_flutter does not work properly. but it have to handle every key event on itself like webview_flutter_ewk does. Signed-off-by: Boram Bae <[email protected]> * Remove unnecessary PlatformView APIs Signed-off-by: Boram Bae <[email protected]> * Tidy up based on review Signed-off-by: Boram Bae <[email protected]> * Always Send key event to TextInputChannel * Use SendKeyEvent as the method name for handling key events like others. * SendKeyEvent returns true if the key event has been handled. Signed-off-by: Boram Bae <[email protected]> * Use #if defined() instead of #ifdef Signed-off-by: Boram Bae <[email protected]> * Rename to ShouldNotFilterEvent Signed-off-by: Boram Bae <[email protected]>
swift-kim
pushed a commit
that referenced
this pull request
Dec 9, 2021
* Refactor TextInputChannel * Introduce TizenInputMethodContext * Do not handle key event for PlatformView in TextInputChannel Each PlatformView must Implement to handle key event. After this patch, the input panel of webview_flutter does not work properly. but it have to handle every key event on itself like webview_flutter_ewk does. Signed-off-by: Boram Bae <[email protected]> * Remove unnecessary PlatformView APIs Signed-off-by: Boram Bae <[email protected]> * Tidy up based on review Signed-off-by: Boram Bae <[email protected]> * Always Send key event to TextInputChannel * Use SendKeyEvent as the method name for handling key events like others. * SendKeyEvent returns true if the key event has been handled. Signed-off-by: Boram Bae <[email protected]> * Use #if defined() instead of #ifdef Signed-off-by: Boram Bae <[email protected]> * Rename to ShouldNotFilterEvent Signed-off-by: Boram Bae <[email protected]>
swift-kim
pushed a commit
that referenced
this pull request
Dec 17, 2021
* Refactor TextInputChannel * Introduce TizenInputMethodContext * Remove unnecessary PlatformView APIs * Tidy up based on review * Always Send key event to TextInputChannel * Use #if defined() instead of #ifdef * Rename to ShouldNotFilterEvent Signed-off-by: Boram Bae <[email protected]>
swift-kim
pushed a commit
that referenced
this pull request
Feb 7, 2022
* Refactor TextInputChannel * Introduce TizenInputMethodContext * Remove unnecessary PlatformView APIs * Tidy up based on review * Always Send key event to TextInputChannel * Use #if defined() instead of #ifdef * Rename to ShouldNotFilterEvent Signed-off-by: Boram Bae <[email protected]>
swift-kim
pushed a commit
that referenced
this pull request
Feb 11, 2022
* Refactor TextInputChannel * Introduce TizenInputMethodContext * Remove unnecessary PlatformView APIs * Tidy up based on review * Always Send key event to TextInputChannel * Use #if defined() instead of #ifdef * Rename to ShouldNotFilterEvent Signed-off-by: Boram Bae <[email protected]>
swift-kim
pushed a commit
that referenced
this pull request
May 12, 2022
* Refactor TextInputChannel * Introduce TizenInputMethodContext * Remove unnecessary PlatformView APIs * Tidy up based on review * Always Send key event to TextInputChannel * Use #if defined() instead of #ifdef * Rename to ShouldNotFilterEvent Signed-off-by: Boram Bae <[email protected]>
swift-kim
pushed a commit
that referenced
this pull request
Aug 5, 2022
* Refactor TextInputChannel * Introduce TizenInputMethodContext * Remove unnecessary PlatformView APIs * Tidy up based on review * Always Send key event to TextInputChannel * Use #if defined() instead of #ifdef * Rename to ShouldNotFilterEvent Signed-off-by: Boram Bae <[email protected]>
swift-kim
pushed a commit
that referenced
this pull request
Sep 1, 2022
swift-kim
pushed a commit
that referenced
this pull request
Sep 1, 2022
* Refactor TextInputChannel * Introduce TizenInputMethodContext * Remove unnecessary PlatformView APIs * Tidy up based on review * Always Send key event to TextInputChannel * Use #if defined() instead of #ifdef * Rename to ShouldNotFilterEvent Signed-off-by: Boram Bae <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each PlatformView must Implement to handle key event.
After this patch, the input panel of webview_flutter does not work properly.
but it have to handle every key event on itself like webview_flutter_ewk does.
Signed-off-by: Boram Bae [email protected]