Conversation
4 tasks
This was referenced Aug 18, 2018
jonnor
approved these changes
Aug 20, 2018
Contributor
jonnor
left a comment
There was a problem hiding this comment.
One minor fix requested, then can merge it. But we should not release this until we've verified that this works out with at least one runtime
Gruntfile.coffee
Outdated
| return done err if err | ||
| capabilities = documentation.renderCapabilities (err, capabilities) -> | ||
|
|
||
| changelog = fs.readFileSync 'CHANGES.md', 'utf8' |
Contributor
There was a problem hiding this comment.
Missing one indentation level, and missing check for err
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #59
Fixes #12
Right now protocol schema changes are backwards-compatible. After a grace period that will likely change.