Skip to content

Benchmarks fix#45

Merged
AboudyKreidieh merged 5 commits intomasterfrom
benchmarks_fix
Aug 31, 2018
Merged

Benchmarks fix#45
AboudyKreidieh merged 5 commits intomasterfrom
benchmarks_fix

Conversation

@AboudyKreidieh
Copy link
Member

  • imported changes to the baselines from berkeleyflow
  • cleanup to the docstring to pass pydocstyle --convention=numpy
  • tests to ensure the baselines are running. TODO: check the return is within a reasonable range

Grid/green wave example

Action Dimension: (9, )
"""Evaluates the baseline performance of grid0 without RL control.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No s as per docstring

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this only applies to functions. classes and the start of a file do not need to follow the imperative convention (same applies for all below comments).

Grid/green wave example

Action Dimension: (25, )
"""Evaluates the baseline performance of grid1 without RL control.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No s as per docstring

@@ -0,0 +1,114 @@
"""Evaluates the baseline performance of merge without RL control.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No s as per docstring

@@ -1,5 +1,4 @@
"""
Runner script for environments located in flow/benchmarks.
"""Runs the environments located in flow/benchmarks.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No s as per docstring

@@ -1,9 +1,10 @@
"""
Runner script for environments located in flow/benchmarks.
"""Runs the environments located in flow/benchmarks.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No s as per docstring

this runner script is executed on. This file runs the ARS algorithm in rllib
and utilizes the hyper-parameters specified in:

TODO: add paper reference
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple random search provides a competitive approach to reinforcement learning
by Mania et. al

this runner script is executed on. This file runs the ES algorithm in rllib
and utilizes the hyper-parameters specified in:

TODO: add paper reference
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Evolution Strategies as a Scalable Alternative to Reinforcement Learning
by Salimans et. al.

this runner script is executed on. This file runs the PPO algorithm in rllib
and utilizes the hyper-parameters specified in:

TODO: add paper reference
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proximal Policy Optimization Algorithms
by Schulman et. al.

class TestBaselines(unittest.TestCase):

"""
Tests that the baselines in the benchmarks folder are running and
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no s

"""

def test_bottleneck0(self):
"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We needed this.

Copy link
Member

@eugenevinitsky eugenevinitsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AboudyKreidieh AboudyKreidieh merged commit 04861ca into master Aug 31, 2018
@AboudyKreidieh AboudyKreidieh deleted the benchmarks_fix branch August 31, 2018 20:30
kjang96 pushed a commit to kjang96/flow-1 that referenced this pull request Sep 1, 2018
adding stress tests used to diagnose race conditions
crystalzyan pushed a commit to crystalzyan/flow that referenced this pull request Dec 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants