Skip to content

[Migration: js to tsx] HeaderPrimary.js converted to HeaderPrimary.tsx - #4052

Merged
SychO9 merged 3 commits into
flarum:2.xfrom
ksvijayan06:vijayan
Oct 2, 2024
Merged

[Migration: js to tsx] HeaderPrimary.js converted to HeaderPrimary.tsx#4052
SychO9 merged 3 commits into
flarum:2.xfrom
ksvijayan06:vijayan

Conversation

@ksvijayan06

@ksvijayan06 ksvijayan06 commented Oct 1, 2024

Copy link
Copy Markdown
Contributor

Fixes #3533

Changes proposed in this pull request: Convert core JS to Typescript

Reviewers should focus on: Javascript code has been re-written in Typescript language

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@ksvijayan06
ksvijayan06 requested a review from a team as a code owner October 1, 2024 15:56

@SychO9 SychO9 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Comment thread framework/core/js/src/forum/components/HeaderPrimary.tsx Outdated
@SychO9
SychO9 merged commit 4291918 into flarum:2.x Oct 2, 2024
@SychO9 SychO9 added this to the 2.0 milestone Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Convert core JS to Typescript

2 participants